Changeset 108476 in webkit
- Timestamp:
- Feb 22, 2012 3:20:31 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 13 deleted
- 15 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r108475 r108476 1 2012-02-22 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r108468. 4 http://trac.webkit.org/changeset/108468 5 https://bugs.webkit.org/show_bug.cgi?id=79219 6 7 Broke Chromium Win release build (Requested by bashi on 8 #webkit). 9 10 * http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed. 11 * http/tests/websocket/tests/hybi/compressed-control-frame.html: Removed. 12 * http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Removed. 13 * http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Removed. 14 * http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Removed. 15 * http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed. 16 * http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Removed. 17 * http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Removed. 18 * http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed. 19 * http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Removed. 20 * http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Removed. 21 * http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt: 22 * http/tests/websocket/tests/hybi/send-file-blob_wsh.py: 23 (web_socket_transfer_data): 24 1 25 2012-02-22 Philippe Normand <pnormand@igalia.com> 2 26 -
trunk/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt
r108468 r108476 1 CONSOLE MESSAGE: Received unexpected extension: x-foo1 CONSOLE MESSAGE: Received unexpected Sec-WebSocket-Extensions header 2 2 Test whether WebSocket handshake fails if the server sends Sec-WebSocket-Extensions header. 3 3 -
trunk/LayoutTests/http/tests/websocket/tests/hybi/send-file-blob_wsh.py
r108468 r108476 1 1 from mod_pywebsocket import common 2 2 from mod_pywebsocket import msgutil 3 4 5 def _retrieve_frame(stream):6 # FIXME: Use better API.7 frame = stream._receive_frame_as_frame_object()8 for frame_filter in stream._options.incoming_frame_filters:9 frame_filter.filter(frame)10 return frame11 3 12 4 … … 19 11 20 12 for test_number, expected_message in enumerate(expected_messages): 21 frame = _retrieve_frame(request.ws_stream) 22 if frame.opcode == common.OPCODE_BINARY and frame.payload == expected_message and frame.fin: 13 # FIXME: Use better API. 14 opcode, payload, final, unused_reserved1, unused_reserved2, unused_reserved3 = request.ws_stream._receive_frame() 15 if opcode == common.OPCODE_BINARY and payload == expected_message and final: 23 16 msgutil.send_message(request, 'PASS: Message #%d.' % test_number) 24 17 else: 25 msgutil.send_message(request, 'FAIL: Message #%d: Received unexpected frame: opcode = %r, payload = %r, final = %r' % (test_number, frame.opcode, frame.payload, frame.fin))18 msgutil.send_message(request, 'FAIL: Message #%d: Received unexpected frame: opcode = %r, payload = %r, final = %r' % (test_number, opcode, payload, final)) 26 19 27 20 -
trunk/Source/JavaScriptCore/ChangeLog
r108468 r108476 1 2012-02-22 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r108468. 4 http://trac.webkit.org/changeset/108468 5 https://bugs.webkit.org/show_bug.cgi?id=79219 6 7 Broke Chromium Win release build (Requested by bashi on 8 #webkit). 9 10 * wtf/Platform.h: 11 1 12 2012-02-22 Kenichi Ishibashi <bashi@chromium.org> 2 13 -
trunk/Source/JavaScriptCore/wtf/Platform.h
r108468 r108476 1194 1194 #endif 1195 1195 1196 #if !PLATFORM(QT) && !PLATFORM(EFL)1197 #define WTF_USE_ZLIB 11198 #endif1199 1200 1196 #endif /* WTF_Platform_h */ -
trunk/Source/WebCore/CMakeLists.txt
r108468 r108476 2057 2057 websockets/WebSocket.cpp 2058 2058 websockets/WebSocketChannel.cpp 2059 websockets/WebSocketDeflateFramer.cpp2060 2059 websockets/WebSocketExtensionDispatcher.cpp 2061 2060 websockets/WebSocketHandshake.cpp -
trunk/Source/WebCore/ChangeLog
r108474 r108476 1 2012-02-22 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r108468. 4 http://trac.webkit.org/changeset/108468 5 https://bugs.webkit.org/show_bug.cgi?id=79219 6 7 Broke Chromium Win release build (Requested by bashi on 8 #webkit). 9 10 * CMakeLists.txt: 11 * GNUmakefile.list.am: 12 * Target.pri: 13 * WebCore.gypi: 14 * WebCore.vcproj/WebCore.vcproj: 15 * WebCore.xcodeproj/project.pbxproj: 16 * websockets/WebSocket.cpp: 17 (WebCore::WebSocket::didConnect): 18 * websockets/WebSocketChannel.cpp: 19 (WebCore::WebSocketChannel::connect): 20 (WebCore::WebSocketChannel::fail): 21 (WebCore::WebSocketChannel::processFrame): 22 (WebCore::WebSocketChannel::sendFrame): 23 * websockets/WebSocketChannel.h: 24 * websockets/WebSocketDeflateFramer.cpp: Removed. 25 * websockets/WebSocketDeflateFramer.h: Removed. 26 1 27 2012-02-20 Roland Steiner <rolandsteiner@chromium.org> 2 28 -
trunk/Source/WebCore/GNUmakefile.list.am
r108468 r108476 4340 4340 Source/WebCore/websockets/WebSocket.cpp \ 4341 4341 Source/WebCore/websockets/WebSocket.h \ 4342 Source/WebCore/websockets/WebSocketDeflateFramer.cpp \4343 Source/WebCore/websockets/WebSocketDeflateFramer.h \4344 4342 Source/WebCore/websockets/WebSocketDeflater.cpp \ 4345 4343 Source/WebCore/websockets/WebSocketDeflater.h \ -
trunk/Source/WebCore/Target.pri
r108468 r108476 3667 3667 websockets/WebSocketChannel.h \ 3668 3668 websockets/WebSocketChannelClient.h \ 3669 websockets/WebSocketDeflateFramer.h \3670 3669 websockets/WebSocketExtensionDispatcher.h \ 3671 3670 websockets/WebSocketExtensionProcessor.h \ … … 3679 3678 websockets/WebSocket.cpp \ 3680 3679 websockets/WebSocketChannel.cpp \ 3681 websockets/WebSocketDeflateFramer.cpp \3682 3680 websockets/WebSocketExtensionDispatcher.cpp \ 3683 3681 websockets/WebSocketHandshake.cpp \ -
trunk/Source/WebCore/WebCore.gypi
r108468 r108476 4818 4818 'websockets/WebSocketChannel.h', 4819 4819 'websockets/WebSocketChannelClient.h', 4820 'websockets/WebSocketDeflateFramer.cpp',4821 'websockets/WebSocketDeflateFramer.h',4822 4820 'websockets/WebSocketDeflater.cpp', 4823 4821 'websockets/WebSocketDeflater.h', -
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
r108468 r108476 73463 73463 </File> 73464 73464 <File 73465 RelativePath="..\websockets\WebSocketDeflateFramer.cpp"73466 >73467 </File>73468 <File73469 RelativePath="..\websockets\WebSocketDeflateFramer.h"73470 >73471 </File>73472 <File73473 73465 RelativePath="..\websockets\WebSocketDeflater.cpp" 73474 73466 > -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r108468 r108476 1368 1368 4A1E71A514E106AC00626F9D /* JSShadowRoot.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4A1E71A314E106AC00626F9D /* JSShadowRoot.cpp */; }; 1369 1369 4A1E71A614E106AC00626F9D /* JSShadowRoot.h in Headers */ = {isa = PBXBuildFile; fileRef = 4A1E71A414E106AC00626F9D /* JSShadowRoot.h */; }; 1370 4A29222B14F468BA0021F77E /* WebSocketDeflateFramer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4A29222914F468BA0021F77E /* WebSocketDeflateFramer.cpp */; };1371 4A29222C14F468BA0021F77E /* WebSocketDeflateFramer.h in Headers */ = {isa = PBXBuildFile; fileRef = 4A29222A14F468BA0021F77E /* WebSocketDeflateFramer.h */; };1372 1370 4A4A234614F1E1440046FBF1 /* WebSocketFrame.h in Headers */ = {isa = PBXBuildFile; fileRef = 4A4A234514F1E1440046FBF1 /* WebSocketFrame.h */; }; 1373 1371 4A6E9FC313C17D1D0046A7F8 /* FontFeatureValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4A6E9FC113C17D1D0046A7F8 /* FontFeatureValue.cpp */; }; … … 8234 8232 4A1E71A314E106AC00626F9D /* JSShadowRoot.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSShadowRoot.cpp; sourceTree = "<group>"; }; 8235 8233 4A1E71A414E106AC00626F9D /* JSShadowRoot.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSShadowRoot.h; sourceTree = "<group>"; }; 8236 4A29222914F468BA0021F77E /* WebSocketDeflateFramer.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebSocketDeflateFramer.cpp; sourceTree = "<group>"; };8237 4A29222A14F468BA0021F77E /* WebSocketDeflateFramer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebSocketDeflateFramer.h; sourceTree = "<group>"; };8238 8234 4A4A234514F1E1440046FBF1 /* WebSocketFrame.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebSocketFrame.h; sourceTree = "<group>"; }; 8239 8235 4A6E9FC113C17D1D0046A7F8 /* FontFeatureValue.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FontFeatureValue.cpp; sourceTree = "<group>"; }; … … 14859 14855 510D4A48103177A20049EA54 /* WebSocketChannel.h */, 14860 14856 510D4A49103177A20049EA54 /* WebSocketChannelClient.h */, 14861 4A29222914F468BA0021F77E /* WebSocketDeflateFramer.cpp */,14862 4A29222A14F468BA0021F77E /* WebSocketDeflateFramer.h */,14863 14857 4AE02ABB14E8A9D200BC3BA7 /* WebSocketDeflater.cpp */, 14864 14858 4AE02ABC14E8A9D200BC3BA7 /* WebSocketDeflater.h */, … … 24251 24245 510D4A4F103177A20049EA54 /* WebSocketChannel.h in Headers */, 24252 24246 510D4A50103177A20049EA54 /* WebSocketChannelClient.h in Headers */, 24253 4A29222C14F468BA0021F77E /* WebSocketDeflateFramer.h in Headers */,24254 24247 4AE02ABE14E8A9D200BC3BA7 /* WebSocketDeflater.h in Headers */, 24255 24248 4A957F0714E241300049DBFB /* WebSocketExtensionDispatcher.h in Headers */, … … 27211 27204 518A34C11026C831001B6896 /* WebSocket.cpp in Sources */, 27212 27205 510D4A4E103177A20049EA54 /* WebSocketChannel.cpp in Sources */, 27213 4A29222B14F468BA0021F77E /* WebSocketDeflateFramer.cpp in Sources */,27214 27206 4AE02ABD14E8A9D200BC3BA7 /* WebSocketDeflater.cpp in Sources */, 27215 27207 4A957F0614E2412A0049DBFB /* WebSocketExtensionDispatcher.cpp in Sources */, -
trunk/Source/WebCore/websockets/WebSocket.cpp
r108468 r108476 479 479 m_state = OPEN; 480 480 m_subprotocol = m_channel->subprotocol(); 481 m_extensions = m_channel->extensions();482 481 dispatchEvent(Event::create(eventNames().openEvent, false, false)); 483 482 } -
trunk/Source/WebCore/websockets/WebSocketChannel.cpp
r108468 r108476 128 128 m_handshake = adoptPtr(new WebSocketHandshake(url, protocol, m_document, m_useHixie76Protocol)); 129 129 m_handshake->reset(); 130 if (!m_useHixie76Protocol && m_deflateFramer.canDeflate())131 m_handshake->addExtensionProcessor(m_deflateFramer.createExtensionProcessor());132 130 if (m_identifier) 133 131 InspectorInstrumentation::didCreateWebSocket(m_document, m_identifier, url, m_document->url()); … … 231 229 if (m_buffer) 232 230 skipBuffer(m_bufferSize); // Save memory. 233 m_deflateFramer.didFail();234 231 m_hasContinuousFrame = false; 235 232 m_continuousFrameData.clear(); … … 621 618 ASSERT(m_buffer < frameEnd); 622 619 ASSERT(frameEnd <= m_buffer + m_bufferSize); 623 624 InflateResultHolder inflateResult = m_deflateFramer.inflate(frame);625 if (!inflateResult.succeeded()) {626 fail(inflateResult.failureReason());627 return false;628 }629 620 630 621 // Validate the frame data. … … 1021 1012 ASSERT(!(opCode & ~opCodeMask)); // Checks whether "opCode" fits in the range of opCodes. 1022 1013 WebSocketFrame frame(opCode, true, false, true, data, dataLength); 1023 1024 DeflateResultHolder deflateResult = m_deflateFramer.deflate(frame);1025 if (!deflateResult.succeeded()) {1026 fail(deflateResult.failureReason());1027 return false;1028 }1029 1030 1014 Vector<char> frameData; 1031 1015 makeFrameData(frame, frameData); -
trunk/Source/WebCore/websockets/WebSocketChannel.h
r108468 r108476 38 38 #include "ThreadableWebSocketChannel.h" 39 39 #include "Timer.h" 40 #include "WebSocketDeflateFramer.h"41 40 #include "WebSocketFrame.h" 42 41 #include "WebSocketHandshake.h" … … 233 232 BlobLoaderStatus m_blobLoaderStatus; 234 233 #endif 235 236 WebSocketDeflateFramer m_deflateFramer;237 234 }; 238 235
Note: See TracChangeset
for help on using the changeset viewer.