Changeset 108902 in webkit

Timestamp:

Feb 25, 2012 10:25:33 AM (12 years ago)

Author:

enne@google.com

Message:

[chromium] Unreviewed gardening, fix Linux Clang OwnPtr breakage
​https://bugs.webkit.org/show_bug.cgi?id=78404

r108886 doesn't compile on Linux Clang due to OwnPtr's public copy
constructor (i.e. "has internal linkage but is not defined"). Fixed
locally by changing copy initialization to direct initialization.

• tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• tests/TiledLayerChromiumTest.cpp (modified) (5 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-02-25  Adrienne Walker  <enne@google.com>
+
+        [chromium] Unreviewed gardening, fix Linux Clang OwnPtr breakage
+        https://bugs.webkit.org/show_bug.cgi?id=78404
+
+        r108886 doesn't compile on Linux Clang due to OwnPtr's public copy
+        constructor (i.e. "has internal linkage but is not defined"). Fixed
+        locally by changing copy initialization to direct initialization.
+
+        * tests/TiledLayerChromiumTest.cpp:
+        (WTF::TEST):
+
 2012-02-24  Tien-Ren Chen  <trchen@chromium.org>
 

trunk/Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp

@@ -232 +232 @@
     RefPtr<FakeTiledLayerChromium> layer = adoptRef(new FakeTiledLayerChromium(textureManager.get()));
     DebugScopedSetImplThread implThread;
-    OwnPtr<FakeCCTiledLayerImpl> layerImpl = adoptPtr(new FakeCCTiledLayerImpl(0));
+    OwnPtr<FakeCCTiledLayerImpl> layerImpl(adoptPtr(new FakeCCTiledLayerImpl(0)));
 
     FakeTextureAllocator textureAllocator;
@@ -267 +267 @@
     RefPtr<FakeTiledLayerChromium> layer = adoptRef(new FakeTiledLayerChromium(textureManager.get()));
     DebugScopedSetImplThread implThread;
-    OwnPtr<FakeCCTiledLayerImpl> layerImpl = adoptPtr(new FakeCCTiledLayerImpl(0));
+    OwnPtr<FakeCCTiledLayerImpl> layerImpl(adoptPtr(new FakeCCTiledLayerImpl(0)));
 
     FakeTextureAllocator textureAllocator;
@@ -333 +333 @@
     RefPtr<FakeTiledLayerChromium> layer = adoptRef(new FakeTiledLayerChromium(textureManager.get()));
     DebugScopedSetImplThread implThread;
-    OwnPtr<FakeCCTiledLayerImpl> layerImpl = adoptPtr(new FakeCCTiledLayerImpl(0));
+    OwnPtr<FakeCCTiledLayerImpl> layerImpl(adoptPtr(new FakeCCTiledLayerImpl(0)));
 
     FakeTextureAllocator textureAllocator;
@@ -369 +369 @@
     RefPtr<FakeTiledLayerChromium> layer = adoptRef(new FakeTiledLayerChromium(textureManager.get()));
     DebugScopedSetImplThread implThread;
-    OwnPtr<FakeCCTiledLayerImpl> layerImpl = adoptPtr(new FakeCCTiledLayerImpl(0));
+    OwnPtr<FakeCCTiledLayerImpl> layerImpl(adoptPtr(new FakeCCTiledLayerImpl(0)));
 
     FakeTextureAllocator textureAllocator;
@@ -449 +449 @@
     RefPtr<FakeTiledLayerChromium> layer = adoptRef(new FakeTiledLayerChromium(textureManager.get()));
     DebugScopedSetImplThread implThread;
-    OwnPtr<FakeCCTiledLayerImpl> layerImpl = adoptPtr(new FakeCCTiledLayerImpl(0));
+    OwnPtr<FakeCCTiledLayerImpl> layerImpl(adoptPtr(new FakeCCTiledLayerImpl(0)));
 
     FakeTextureAllocator textureAllocator;