Changeset 109169 in webkit

Timestamp:

Feb 28, 2012 4:37:05 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

All mouse events after a right click are ignored when they came from WebkitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=77350

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-02-28
Reviewed by Chang Shu.

Source/WebKit2:

Never ignore mouse events when using sync events, even if the context menu is being
show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEventSyncForTesting):

LayoutTests:

Unskip fast/events/mouse-click-events.html.

• platform/qt-5.0-wk2/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt-5.0-wk2/Skipped (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-28  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        All mouse events after a right click are ignored when they came from WebkitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=77350
+
+        Reviewed by Chang Shu.
+
+        Unskip fast/events/mouse-click-events.html.
+
+        * platform/qt-5.0-wk2/Skipped:
+
 2012-02-28  Rafael Brandao  <rafael.lobo@openbossa.org>
 

trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

@@ -55 +55 @@
 fast/events/continuous-platform-wheelevent-in-scrolling-div.html
 fast/events/fire-mousedown-while-pressing-mouse-button.html
-fast/events/mouse-click-events.html
 fast/events/mouseup-from-button2.html
 fast/events/open-window-from-another-frame.html

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-02-28  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        All mouse events after a right click are ignored when they came from WebkitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=77350
+
+        Reviewed by Chang Shu.
+
+        Never ignore mouse events when using sync events, even if the context menu is being
+        show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::mouseEventSyncForTesting):
+
 2012-02-28  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -1300 +1300 @@
 void WebPage::mouseEventSyncForTesting(const WebMouseEvent& mouseEvent, bool& handled)
 {
-    // Don't try to handle any pending mouse events if a context menu is showing.
-    if (m_isShowingContextMenu) {
-        handled = true;
-        return;
-    }
-
     handled = m_pageOverlay && m_pageOverlay->mouseEvent(mouseEvent);