Changeset 109382 in webkit


Ignore:
Timestamp:
Mar 1, 2012 11:47:44 AM (12 years ago)
Author:
bashi@chromium.org
Message:

REGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=79448

Reviewed by Ryosuke Niwa.

Source/WebCore:

Don't produce single quotes around face attribute of font elements.

Test: editing/style/font-face-unquote.html

  • editing/EditingStyle.cpp:

(WebCore::StyleChange::extractTextStyles): Remove single quotes from m_applyFontFace.

LayoutTests:

Add a test that makes sure WebKit doesn't produce single quotes around
face attribute of font element.

  • editing/style/font-face-unquote-expected.txt: Added.
  • editing/style/font-face-unquote.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r109375 r109382  
     12012-03-01  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        REGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit
     4        https://bugs.webkit.org/show_bug.cgi?id=79448
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Add a test that makes sure WebKit doesn't produce single quotes around
     9        face attribute of font element.
     10
     11        * editing/style/font-face-unquote-expected.txt: Added.
     12        * editing/style/font-face-unquote.html: Added.
     13
    1142012-03-01  Adam Klein  <adamk@chromium.org>
    215
  • trunk/Source/WebCore/ChangeLog

    r109379 r109382  
     12012-03-01  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        REGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit
     4        https://bugs.webkit.org/show_bug.cgi?id=79448
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Don't produce single quotes around face attribute of font elements.
     9
     10        Test: editing/style/font-face-unquote.html
     11
     12        * editing/EditingStyle.cpp:
     13        (WebCore::StyleChange::extractTextStyles): Remove single quotes from m_applyFontFace.
     14
    1152012-03-01  Beth Dakin  <bdakin@apple.com>
    216
  • trunk/Source/WebCore/editing/EditingStyle.cpp

    r109116 r109382  
    13801380
    13811381    m_applyFontFace = style->getPropertyValue(CSSPropertyFontFamily);
     1382    // Remove single quotes for Outlook 2007 compatibility. See https://bugs.webkit.org/show_bug.cgi?id=79448
     1383    m_applyFontFace.replace('\'', "");
    13821384    style->removeProperty(CSSPropertyFontFamily);
    13831385
Note: See TracChangeset for help on using the changeset viewer.