Changeset 109417 in webkit

Timestamp:

Mar 1, 2012 1:53:23 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

:empty still applies to elements made non-empty via page dynamics.
​https://bugs.webkit.org/show_bug.cgi?id=79734

Check for :empty style change should be made even if the RenderStyle for the element is NULL
as changes to the element's children can trigger a change in :empty state of the parent element.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-03-01
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/selectors/empty-element-made-non-empty.html

• dom/Element.cpp:

(WebCore::checkForSiblingStyleChanges):

LayoutTests:

• fast/selectors/empty-element-made-non-empty-expected.txt: Added.
• fast/selectors/empty-element-made-non-empty.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/selectors/empty-element-made-non-empty-expected.txt (added)
• LayoutTests/fast/selectors/empty-element-made-non-empty.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-01  Joe Thomas  <joethomas@motorola.com>
+
+        :empty still applies to elements made non-empty via page dynamics.
+        https://bugs.webkit.org/show_bug.cgi?id=79734
+
+        Check for :empty style change should be made even if the RenderStyle for the element is NULL
+        as changes to the element's children can trigger a change in :empty state of the parent element.
+
+        Reviewed by Antti Koivisto.
+
+        * fast/selectors/empty-element-made-non-empty-expected.txt: Added.
+        * fast/selectors/empty-element-made-non-empty.html: Added.
+
 2012-03-01  Kangil Han  <kangil.han@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-01  Joe Thomas  <joethomas@motorola.com>
+
+        :empty still applies to elements made non-empty via page dynamics.
+        https://bugs.webkit.org/show_bug.cgi?id=79734
+
+        Check for :empty style change should be made even if the RenderStyle for the element is NULL
+        as changes to the element's children can trigger a change in :empty state of the parent element.
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/selectors/empty-element-made-non-empty.html
+
+        * dom/Element.cpp:
+        (WebCore::checkForSiblingStyleChanges):
+
 2012-02-29  Nat Duca  <nduca@chromium.org>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1216 +1216 @@
                                         Node* beforeChange, Node* afterChange, int childCountDelta)
 {
+    // :empty selector.
+    checkForEmptyStyleChange(e, style);
+    
     if (!style || (e->needsStyleRecalc() && style->childrenAffectedByPositionalRules()))
         return;
@@ -1287 +1290 @@
         (style->childrenAffectedByBackwardPositionalRules() && beforeChange))
         e->setNeedsStyleRecalc();
-    
-    // :empty selector.
-    checkForEmptyStyleChange(e, style);
 }