Changeset 109521 in webkit

Timestamp:

Mar 2, 2012 12:11:42 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Send didCommitAndDrawFrame after swap
​https://bugs.webkit.org/show_bug.cgi?id=80052

Patch by John Bauman <​jbauman@chromium.org> on 2012-03-02
Reviewed by James Robinson.

Sending didCommitAndDrawFrame before the swap was causing plugins to
redraw themselves between compositing and the swap, which reduces
opportunities for optimization.

• platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
(WebCore):
(WebCore::CCSingleThreadProxy::didSwapFrame):

• platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/cc/CCSingleThreadProxy.cpp (modified) (3 diffs)
• platform/graphics/chromium/cc/CCSingleThreadProxy.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-02  John Bauman  <jbauman@chromium.org>
+
+        [chromium] Send didCommitAndDrawFrame after swap
+        https://bugs.webkit.org/show_bug.cgi?id=80052
+
+        Reviewed by James Robinson.
+
+        Sending didCommitAndDrawFrame before the swap was causing plugins to
+        redraw themselves between compositing and the swap, which reduces
+        opportunities for optimization.
+
+        * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+        (WebCore::CCSingleThreadProxy::compositeAndReadback):
+        (WebCore::CCSingleThreadProxy::compositeImmediately):
+        (WebCore::CCSingleThreadProxy::doComposite):
+        (WebCore):
+        (WebCore::CCSingleThreadProxy::didSwapFrame):
+        * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
+        (CCSingleThreadProxy):
+
 2012-03-02  Raymond Toy  <rtoy@google.com>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp

@@ -81 +81 @@
     m_layerTreeHostImpl->readback(pixels, rect);
 
+    didSwapFrame();
+
     if (m_layerTreeHostImpl->isContextLost())
         return false;
@@ -267 +269 @@
         return;
 
-    if (doComposite())
+    if (doComposite()) {
         m_layerTreeHostImpl->swapBuffers();
+        didSwapFrame();
+    }
 }
 
@@ -298 +302 @@
     }
 
+    return true;
+}
+
+void CCSingleThreadProxy::didSwapFrame()
+{
     if (m_nextFrameIsNewlyCommittedFrame) {
         m_nextFrameIsNewlyCommittedFrame = false;
         m_layerTreeHost->didCommitAndDrawFrame();
     }
-
-    return true;
-}
-
-}
+}
+
+}

trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h

@@ -77 +77 @@
     void doCommit();
     bool doComposite();
+    void didSwapFrame();
 
     // Accessed on main thread only.