Changeset 109544 in webkit

Timestamp:

Mar 2, 2012 2:55:35 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Build warning : comparison between signed and unsigned integer expressions.
​https://bugs.webkit.org/show_bug.cgi?id=79860

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-03-02
Reviewed by Hajime Morita.

Fixed build warnings which are getting generated when comparing signed
and unsigned integer expressions.

• Source/WebCore/bindings/js/JSDocumentCustom.cpp:
• Source/WebCore/platform/ContextMenu.cpp:
• Source/WebKit/efl/ewk/ewk_view_single.cpp:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/JSDocumentCustom.cpp (modified) (1 diff)
• Source/WebCore/platform/ContextMenu.cpp (modified) (1 diff)
• Source/WebKit/efl/ewk/ewk_view_single.cpp (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2012-03-02  Byungwoo Lee  <bw80.lee@samsung.com>
+
+        [EFL] Build warning : comparison between signed and unsigned integer expressions.
+        https://bugs.webkit.org/show_bug.cgi?id=79860
+
+        Reviewed by Hajime Morita.
+
+        Fixed build warnings which are getting generated when comparing signed
+        and unsigned integer expressions.
+
+        * Source/WebCore/bindings/js/JSDocumentCustom.cpp:
+        * Source/WebCore/platform/ContextMenu.cpp:
+        * Source/WebKit/efl/ewk/ewk_view_single.cpp:
+
 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
 

trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp

@@ -120 +120 @@
     RefPtr<TouchList> touchList = TouchList::create();
 
-    for (int i = 0; i < exec->argumentCount(); i++)
+    for (size_t i = 0; i < exec->argumentCount(); i++)
         touchList->append(toTouch(exec->argument(i)));
 

trunk/Source/WebCore/platform/ContextMenu.cpp

@@ -39 +39 @@
     for (size_t i = 0; i < items.size(); ++i) {
         const ContextMenuItem& item = items[i];
-        if (item.action() == action)
+        if (item.action() == static_cast<ContextMenuAction>(action))
             return &item;
         if (item.type() != SubmenuType)

trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp

@@ -107 +107 @@
     uint32_t* source, * destination;
     if (sourceX >= destinationX) {
-        for (int i = 0; i < copyHeight; i++) {
+        for (size_t i = 0; i < copyHeight; i++) {
             source = sourceBegin + (frameWidth * startHeight);
             destination = destinationBegin + (frameWidth * startHeight);
@@ -114 +114 @@
         }
     } else {
-        for (int i = 0; i < copyHeight; i++) {
+        for (size_t i = 0; i < copyHeight; i++) {
             source = sourceBegin + (frameWidth * startHeight);
             destination = destinationBegin + (frameWidth * startHeight);