Changeset 109653 in webkit


Ignore:
Timestamp:
Mar 2, 2012 9:48:54 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Editor's default paragraph separator is not reset when a frame's document is changed
​https://bugs.webkit.org/show_bug.cgi?id=80065

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/execCommand/reset-values-after-navigation.html

  • editing/Editor.cpp:

(WebCore::Editor::clear):

LayoutTests:

  • editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
  • editing/execCommand/reset-values-after-navigation-expected.txt: Added.
  • editing/execCommand/reset-values-after-navigation.html: Added.
  • editing/execCommand/resources/reset-default-values-helper-1.html: Added.
  • editing/execCommand/resources/reset-default-values-helper-2.html: Added.
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r109651 r109653  
     12012-03-02  Pablo Flouret  <pablof@motorola.com>
     2
     3        Editor's default paragraph separator is not reset when a frame's document is changed
     4        https://bugs.webkit.org/show_bug.cgi?id=80065
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
     9        * editing/execCommand/reset-values-after-navigation-expected.txt: Added.
     10        * editing/execCommand/reset-values-after-navigation.html: Added.
     11        * editing/execCommand/resources/reset-default-values-helper-1.html: Added.
     12        * editing/execCommand/resources/reset-default-values-helper-2.html: Added.
     13
    1142012-03-02  Noel Gordon  <noel.gordon@gmail.com>
    215

  • trunk/LayoutTests/editing/execCommand/default-paragraph-separator.html

    r109529 r109653  
    7575
    7676    div.innerHTML = "";
    77     document.execCommand("DefaultParagraphSeparator", false, "div");
    7877</script>
    7978<script src="../../fast/js/resources/js-test-post.js"></script>

  • trunk/Source/WebCore/ChangeLog

    r109652 r109653  
     12012-03-02  Pablo Flouret  <pablof@motorola.com>
     2
     3        Editor's default paragraph separator is not reset when a frame's document is changed
     4        https://bugs.webkit.org/show_bug.cgi?id=80065
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Test: editing/execCommand/reset-values-after-navigation.html
     9
     10        * editing/Editor.cpp:
     11        (WebCore::Editor::clear):
     12
    1132012-03-02  Alexey Proskuryakov  <ap@apple.com>
    214

  • trunk/Source/WebCore/editing/Editor.cpp

    r109529 r109653  
    860860    m_customCompositionUnderlines.clear();
    861861    m_shouldStyleWithCSS = false;
     862    m_defaultParagraphSeparator = EditorParagraphSeparatorIsDiv;
    862863}
    863864
Note: See TracChangeset for help on using the changeset viewer.