Changeset 109702 in webkit

Timestamp:

Mar 4, 2012 8:09:39 PM (12 years ago)

Author:

morrita@google.com

Message:

WebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
​https://bugs.webkit.org/show_bug.cgi?id=80229

Reviewed by Kent Tamura.

The code generator has naked static_cast<> which could be unsafe.
We can turn it into toHTMLUnknownElement() and the like.

No new tests. Just added a sanity check.

• dom/make_names.pl:

(printWrapperFactoryCppFile):

• html/HTMLElement.h:

(HTMLElement):
(WebCore::HTMLElement::isHTMLUnknownElement):

• html/HTMLUnknownElement.h:

(HTMLUnknownElement):
(WebCore::toHTMLUnknownElement):
(WebCore):

• mathml/MathMLElement.h:

(toMathMLElement):

• svg/SVGElement.h:

(WebCore::toSVGElement):
(WebCore):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/make_names.pl (modified) (1 diff)
• html/HTMLElement.h (modified) (1 diff)
• html/HTMLUnknownElement.h (modified) (2 diffs)
• mathml/MathMLElement.h (modified) (1 diff)
• svg/SVGElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-04  MORITA Hajime  <morrita@google.com>
+
+        WebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
+        https://bugs.webkit.org/show_bug.cgi?id=80229
+
+        Reviewed by Kent Tamura.
+
+        The code generator has naked static_cast<> which could be unsafe.
+        We can turn it into toHTMLUnknownElement() and the like.
+
+        No new tests. Just added a sanity check.
+
+        * dom/make_names.pl:
+        (printWrapperFactoryCppFile):
+        * html/HTMLElement.h:
+        (HTMLElement):
+        (WebCore::HTMLElement::isHTMLUnknownElement):
+        * html/HTMLUnknownElement.h:
+        (HTMLUnknownElement):
+        (WebCore::toHTMLUnknownElement):
+        (WebCore):
+        * mathml/MathMLElement.h:
+        (toMathMLElement):
+        * svg/SVGElement.h:
+        (WebCore::toSVGElement):
+        (WebCore):
+
 2012-03-04  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/dom/make_names.pl

@@ -1162 +1162 @@
         print F <<END
         return createWrapperFunction(element);
-    return V8$parameters{fallbackInterfaceName}::wrap(static_cast<$parameters{fallbackInterfaceName}*>(element), forceNewObject);
+    return V8$parameters{fallbackInterfaceName}::wrap(to$parameters{fallbackInterfaceName}(element), forceNewObject);
 END
 ;

trunk/Source/WebCore/html/HTMLElement.h

@@ -98 +98 @@
 #endif
 
+#ifndef NDEBUG
+    virtual bool isHTMLUnknownElement() const { return false; }
+#endif
+
 protected:
     HTMLElement(const QualifiedName& tagName, Document*);

trunk/Source/WebCore/html/HTMLUnknownElement.h

@@ -42 +42 @@
     }
 
+#ifndef NDEBUG
+    virtual bool isHTMLUnknownElement() const OVERRIDE { return true; }
+#endif
+
 private:
     HTMLUnknownElement(const QualifiedName& tagName, Document* document)
@@ -49 +53 @@
 };
 
+inline HTMLUnknownElement* toHTMLUnknownElement(HTMLElement* element)
+{
+    ASSERT(!element || element->isHTMLUnknownElement());
+    return static_cast<HTMLUnknownElement*>(element);
+}
+
 } // namespace
 

trunk/Source/WebCore/mathml/MathMLElement.h

@@ -49 +49 @@
 }
 
+inline MathMLElement* toMathMLElement(Element* element)
+{
+    ASSERT(!element || element->isMathMLElement());
+    return static_cast<MathMLElement*>(element);
+}
+
 #endif // ENABLE(MATHML)
 #endif // MathMLElement_h

trunk/Source/WebCore/svg/SVGElement.h

@@ -149 +149 @@
 };
 
+inline SVGElement* toSVGElement(Element* element)
+{
+    ASSERT(!element || element->isSVGElement());
+    return static_cast<SVGElement*>(element);
+}
+
 }