Changeset 109816 in webkit


Ignore:
Timestamp:
Mar 5, 2012 4:45:37 PM (12 years ago)
Author:
tkent@chromium.org
Message:

[Chromium] Add new popup type: PagePopup
​https://bugs.webkit.org/show_bug.cgi?id=80106

Reviewed by Darin Fisher.

Source/WebKit/chromium:

This is a preparation of implementing ChromeClient::openPagePopup and
closePagePopup.

  • WebKit.gyp: Add WebPagePopup.h and WebPagePopupImpl.cpp.
  • public/WebPagePopup.h:

(WebPagePopup): Add WebPagePopup interface.

  • public/WebPopupType.h: Add WebPopupTypePage.
  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopup::create): Temprary implementation which just returns 0.

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPopupMenu):

Location:
trunk
Files:
5 edited
2 copied

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/chromium/ChangeLog

    r109778 r109816  
     12012-03-05  Kent Tamura  <tkent@chromium.org>
     2
     3        [Chromium] Add new popup type: PagePopup
     4        https://bugs.webkit.org/show_bug.cgi?id=80106
     5
     6        Reviewed by Darin Fisher.
     7
     8        This is a preparation of implementing ChromeClient::openPagePopup and
     9        closePagePopup.
     10
     11        * WebKit.gyp: Add WebPagePopup.h and WebPagePopupImpl.cpp.
     12        * public/WebPagePopup.h:
     13        (WebPagePopup): Add WebPagePopup interface.
     14        * public/WebPopupType.h: Add WebPopupTypePage.
     15        * src/WebPagePopupImpl.cpp:
     16        (WebKit::WebPagePopup::create): Temprary implementation which just returns 0.
     17
    1182012-03-05  Charlie Reis  <creis@chromium.org>
    219

  • trunk/Source/WebKit/chromium/WebKit.gyp

    r108877 r109816  
    216216                'public/WebOptionElement.h',
    217217                'public/WebPageOverlay.h',
     218                'public/WebPagePopup.h',
    218219                'public/WebPageSerializer.h',
    219220                'public/WebPageSerializerClient.h',
    … …  
    616617                'src/WebNotification.cpp',
    617618                'src/WebOptionElement.cpp',
     619                'src/WebPagePopupImpl.cpp',
    618620                'src/WebPageSerializer.cpp',
    619621                'src/WebPageSerializerImpl.cpp',

  • trunk/Source/WebKit/chromium/public/WebPagePopup.h

    r109815 r109816  
    11/*
    2  * Copyright (C) 2010 Google Inc. All rights reserved.
     2 * Copyright (C) 2012 Google Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2929 */
    3030
    31 #ifndef WebPopupType_h
    32 #define WebPopupType_h
     31#ifndef WebPagePopup_h
     32#define WebPagePopup_h
     33
     34#include "WebWidget.h"
     35#include "platform/WebCommon.h"
    3336
    3437namespace WebKit {
    3538
    36 enum WebPopupType {
    37     WebPopupTypeNone, // Not a popup.
    38     WebPopupTypeSelect, // A HTML select (combo-box) popup.
    39     WebPopupTypeSuggestion, // An autofill/autocomplete popup.
     39class WebWidgetClient;
     40
     41class WebPagePopup : public WebWidget {
     42public:
     43    WEBKIT_EXPORT static WebPagePopup* create(WebWidgetClient*);
    4044};
    4145

  • trunk/Source/WebKit/chromium/public/WebPopupType.h

    r95901 r109816  
    3636enum WebPopupType {
    3737    WebPopupTypeNone, // Not a popup.
    38     WebPopupTypeSelect, // A HTML select (combo-box) popup.
     38    WebPopupTypeSelect, // An HTML select (combo-box) popup.
    3939    WebPopupTypeSuggestion, // An autofill/autocomplete popup.
     40    WebPopupTypePage, // An HTML-capable popup.
    4041};
    4142

  • trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp

    r109815 r109816  
    11/*
    2  * Copyright (C) 2010 Google Inc. All rights reserved.
     2 * Copyright (C) 2009 Google Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2929 */
    3030
    31 #ifndef WebPopupType_h
    32 #define WebPopupType_h
     31#include "config.h"
     32
     33#include "WebPagePopup.h"
    3334
    3435namespace WebKit {
    3536
    36 enum WebPopupType {
    37     WebPopupTypeNone, // Not a popup.
    38     WebPopupTypeSelect, // A HTML select (combo-box) popup.
    39     WebPopupTypeSuggestion, // An autofill/autocomplete popup.
    40 };
     37// WebPagePopupImpl ----------------------------------------------------------------
     38
     39// FIXME: WebPagePopupImpl implementation will be written here.
     40
     41// WebPagePopup ----------------------------------------------------------------
     42
     43WebPagePopup* WebPagePopup::create(WebWidgetClient*)
     44{
     45    // FIXME: Returns a WebPagePopupImpl object.
     46    return 0;
     47}
    4148
    4249} // namespace WebKit
    43 
    44 #endif

  • trunk/Tools/ChangeLog

    r109815 r109816  
     12012-03-05  Kent Tamura  <tkent@chromium.org>
     2
     3        [Chromium] Add new popup type: PagePopup
     4        https://bugs.webkit.org/show_bug.cgi?id=80106
     5
     6        Reviewed by Darin Fisher.
     7
     8        * DumpRenderTree/chromium/WebViewHost.cpp:
     9        (WebViewHost::createPopupMenu):
     10
    1112012-03-05  Jessie Berlin  <jberlin@apple.com>
    212

  • trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp

    r109778 r109816  
    256256    switch (type) {
    257257    case WebKit::WebPopupTypeNone:
     258    case WebKit::WebPopupTypePage:
    258259        break;
    259260    case WebKit::WebPopupTypeSelect:
Note: See TracChangeset for help on using the changeset viewer.