Changeset 110004 in webkit

Timestamp:

Mar 6, 2012 7:53:17 PM (12 years ago)

Author:

haraken@chromium.org

Message:

Unreviewed, rolling out r109969.
​http://trac.webkit.org/changeset/109969
​https://bugs.webkit.org/show_bug.cgi?id=80376

layout tests crash

• bindings/v8/V8HiddenPropertyName.cpp:

(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):

• bindings/v8/V8HiddenPropertyName.h:

(WebCore):
(V8HiddenPropertyName):

• bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

• bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

• bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8HiddenPropertyName.cpp (modified) (2 diffs)
• bindings/v8/V8HiddenPropertyName.h (modified) (2 diffs)
• bindings/v8/custom/V8DOMStringMapCustom.cpp (modified) (1 diff)
• bindings/v8/custom/V8DOMTokenListCustom.cpp (modified) (1 diff)
• bindings/v8/custom/V8NamedNodeMapCustom.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-06  Kentaro Hara  <haraken@chromium.org>
+
+        Unreviewed, rolling out r109969.
+        http://trac.webkit.org/changeset/109969
+        https://bugs.webkit.org/show_bug.cgi?id=80376
+
+        layout tests crash
+
+        * bindings/v8/V8HiddenPropertyName.cpp:
+        (WebCore):
+        (WebCore::V8HiddenPropertyName::hiddenReferenceName):
+        * bindings/v8/V8HiddenPropertyName.h:
+        (WebCore):
+        (V8HiddenPropertyName):
+        * bindings/v8/custom/V8DOMStringMapCustom.cpp:
+        (WebCore::toV8):
+        * bindings/v8/custom/V8DOMTokenListCustom.cpp:
+        (WebCore::toV8):
+        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
+        (WebCore::toV8):
+
 2012-03-06  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp

@@ -34 +34 @@
 #include "V8Binding.h"
 #include <string.h>
-#include <wtf/StdLibExtras.h>
 #include <wtf/Vector.h>
 
@@ -42 +41 @@
 #define V8_AS_STRING_IMPL(x) #x
 
-#define V8_DEFINE_HIDDEN_PROPERTY(name, prefix) \
+#define V8_DEFINE_PROPERTY(name) \
 v8::Handle<v8::String> V8HiddenPropertyName::name() \
 { \
-    DEFINE_STATIC_LOCAL(v8::Persistent<v8::String>, hiddenPropertyName, (createString(prefix V8_AS_STRING(name)))); \
-    return hiddenPropertyName; \
+    V8HiddenPropertyName* hiddenPropertyName = V8BindingPerIsolateData::current()->hiddenPropertyName(); \
+    if (hiddenPropertyName->m_##name.IsEmpty()) { \
+        hiddenPropertyName->m_##name = createString("WebCore::HiddenProperty::" V8_AS_STRING(name)); \
+    } \
+    return hiddenPropertyName->m_##name; \
 }
 
-V8_HIDDEN_PROPERTIES(V8_DEFINE_HIDDEN_PROPERTY);
+V8_HIDDEN_PROPERTIES(V8_DEFINE_PROPERTY);
+
+static const char hiddenReferenceNamePrefix[] = "WebCore::HiddenReference::";
 
 v8::Handle<v8::String> V8HiddenPropertyName::hiddenReferenceName(const char* name)
 {
     Vector<char, 64> prefixedName;
-    prefixedName.append(V8_HIDDEN_REFERENCE_PREFIX, sizeof(V8_HIDDEN_REFERENCE_PREFIX) - 1);
+    prefixedName.append(hiddenReferenceNamePrefix, sizeof(hiddenReferenceNamePrefix) - 1);
     ASSERT(name && strlen(name));
     prefixedName.append(name, strlen(name));

trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h

@@ -36 +36 @@
 namespace WebCore {
 
-#define V8_HIDDEN_PROPERTY_PREFIX "WebCore::HiddenProperty::"
-#define V8_HIDDEN_REFERENCE_PREFIX "WebCore::HiddenReference::"
+#define V8_HIDDEN_PROPERTIES(V) \
+    V(objectPrototype) \
+    V(listener) \
+    V(attributeListener) \
+    V(scriptState) \
+    V(devtoolsInjectedScript) \
+    V(sleepFunction) \
+    V(toStringString) \
+    V(event) \
+    V(state)
 
-#define V8_HIDDEN_PROPERTIES(V) \
-    V(objectPrototype, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(listener, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(attributeListener, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(scriptState, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(devtoolsInjectedScript, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(sleepFunction, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(toStringString, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(event, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(state, V8_HIDDEN_PROPERTY_PREFIX) \
-    V(domStringMap, V8_HIDDEN_REFERENCE_PREFIX) \
-    V(domTokenList, V8_HIDDEN_REFERENCE_PREFIX) \
-    V(ownerNode, V8_HIDDEN_REFERENCE_PREFIX)
 
     class V8HiddenPropertyName {
     public:
         V8HiddenPropertyName() { }
-#define V8_DECLARE_PROPERTY(name, prefix) static v8::Handle<v8::String> name();
+#define V8_DECLARE_PROPERTY(name) static v8::Handle<v8::String> name();
         V8_HIDDEN_PROPERTIES(V8_DECLARE_PROPERTY);
 #undef V8_DECLARE_PROPERTY
@@ -64 +59 @@
     private:
         static v8::Persistent<v8::String> createString(const char* key);
+#define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name;
+        V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);
+#undef V8_DECLARE_FIELD
     };
 

trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp

@@ -92 +92 @@
     // Add a hidden reference from the element to the DOMStringMap.
     Element* element = impl->element();
-    if (!wrapper.IsEmpty() && element)
-        toV8(element).As<v8::Object>()->SetHiddenValue(V8HiddenPropertyName::domStringMap(), wrapper);
+    if (!wrapper.IsEmpty() && element) {
+        v8::Handle<v8::Value> elementValue = toV8(element);
+        if (!elementValue.IsEmpty() && elementValue->IsObject())
+            V8DOMWrapper::setNamedHiddenReference(elementValue.As<v8::Object>(), "domStringMap", wrapper);
+    }
     return wrapper;
 }

trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp

@@ -46 +46 @@
     // Add a hidden reference from the element to the DOMTokenList.
     Element* element = impl->element();
-    if (!wrapper.IsEmpty() && element)
-        toV8(element).As<v8::Object>()->SetHiddenValue(V8HiddenPropertyName::domTokenList(), wrapper);
+    if (!wrapper.IsEmpty() && element) {
+        v8::Handle<v8::Value> elementValue = toV8(element);
+        if (!elementValue.IsEmpty() && elementValue->IsObject())
+            V8DOMWrapper::setNamedHiddenReference(elementValue.As<v8::Object>(), "domTokenList", wrapper);
+    }
     return wrapper;
 }

trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp

@@ -80 +80 @@
     Element* element = impl->element();
     if (!wrapper.IsEmpty() && element)
-        toV8(element).As<v8::Object>()->SetHiddenValue(V8HiddenPropertyName::ownerNode(), wrapper);
+        V8DOMWrapper::setNamedHiddenReference(wrapper, "ownerNode", toV8(element));
     return wrapper;
 }