Changeset 110401 in webkit

Timestamp:

Mar 11, 2012 3:17:36 PM (12 years ago)

Author:

shawnsingh@chromium.org

Message:

REGRESSION (r93614): scrolling div does not repaint
​https://bugs.webkit.org/show_bug.cgi?id=80641

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/newly-composited-repaint-rect.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): When a layer
becomes newly composited and creates its backing, the repaintRect
may become invalid. This patch recomputes repaintRects in this
case.

LayoutTests:

• compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
• compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
• compositing/repaint/newly-composited-repaint-rect.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/repaint/newly-composited-repaint-rect-expected.png (added)
• LayoutTests/compositing/repaint/newly-composited-repaint-rect-expected.txt (added)
• LayoutTests/compositing/repaint/newly-composited-repaint-rect.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-11  Shawn Singh  <shawnsingh@chromium.org>
+
+        REGRESSION (r93614): scrolling div does not repaint
+        https://bugs.webkit.org/show_bug.cgi?id=80641
+
+        Reviewed by Simon Fraser.
+
+        * compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
+        * compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
+        * compositing/repaint/newly-composited-repaint-rect.html: Added.
+
 2012-03-11  Gavin Barraclough  <barraclough@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-11  Shawn Singh  <shawnsingh@chromium.org>
+
+        REGRESSION (r93614): scrolling div does not repaint
+        https://bugs.webkit.org/show_bug.cgi?id=80641
+
+        Reviewed by Simon Fraser.
+
+        Test: compositing/repaint/newly-composited-repaint-rect.html
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateBacking): When a layer
+        becomes newly composited and creates its backing, the repaintRect
+        may become invalid. This patch recomputes repaintRects in this
+        case.
+
 2012-03-11  George Staikos  <staikos@webkit.org>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -418 +418 @@
             layer->ensureBacking();
 
+            // The RenderLayer's needs to update repaint rects here, because the target
+            // repaintContainer may have changed after becoming a composited layer.
+            // https://bugs.webkit.org/show_bug.cgi?id=80641
+            layer->computeRepaintRects();
+
 #if PLATFORM(MAC) && USE(CA)
             Settings* settings = m_renderView->document()->settings();