Changeset 110700 in webkit

Timestamp:

Mar 14, 2012 8:15:34 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Implement LayoutTestController::clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=80142

Tools:

Adding missing implementation clearBackForwardList to EFL's
LayoutTestController. This implementation allows us to unskip
tests connected with history.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

• DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearBackForwardList): Implemented.

LayoutTests:

Unskip tests connected with clearBackForwardList.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

• platform/efl/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] Implement LayoutTestController::clearBackForwardList
+        https://bugs.webkit.org/show_bug.cgi?id=80142
+
+        Unskip tests connected with clearBackForwardList.
+
+        Reviewed by Antonio Gomes.
+
+        * platform/efl/Skipped: 
+
 2012-03-14  Kentaro Hara  <haraken@chromium.org>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -300 +300 @@
 fast/dom/nodesFromRect-inner-documents.html
 fast/dom/nodesFromRect-links-and-text.html
-
-# EFL's LayoutTestController does not implement clearBackForwardList
-fast/dom/location-hash.html
-fast/events/backspace-navigates-back.html
-fast/history/form-submit-in-frame-via-onclick.html
-fast/history/form-submit-in-frame.html
-fast/history/gesture-before-onload-form-submit.html
-fast/history/gesture-before-onload-location-href.html
-fast/history/history-length.html
-fast/history/redirect-via-iframe.html
-fast/history/same-document-iframes-changing-fragment.html
-fast/history/same-document-iframes-changing-pushstate.html
-fast/loader/frame-location-change-not-added-to-history.html
-fast/loader/frame-src-change-not-added-to-history.html
-fast/loader/location-port.html
-fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
-fast/loader/stateobjects/document-destroyed-navigate-back.html
-fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html
-fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html
-fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html
-fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html
-fast/loader/stateobjects/pushstate-object-types.html
-fast/loader/stateobjects/pushstate-then-replacestate.html
-fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
-fast/loader/stateobjects/pushstate-within-popstate-handler-assert.html
-fast/loader/stateobjects/pushstate-without-history.html
-fast/loader/stateobjects/replacestate-then-pushstate.html
 
 # EFL's LayoutTestController does not implement copy{Encoded,Decoded}HostName

trunk/Tools/ChangeLog

@@ +1 @@
+2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] Implement LayoutTestController::clearBackForwardList
+        https://bugs.webkit.org/show_bug.cgi?id=80142
+
+        Adding missing implementation clearBackForwardList to EFL's
+        LayoutTestController. This implementation allows us to unskip 
+        tests connected with history.
+
+        Reviewed by Antonio Gomes.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::clearBackForwardList): Implemented.
+
 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 

trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

@@ -66 +66 @@
 void LayoutTestController::clearBackForwardList()
 {
-    notImplemented();
+    Ewk_History* history = ewk_view_history_get(browser->mainView());
+    if (!history)
+        return;
+
+    Ewk_History_Item* item = ewk_history_history_item_current_get(history);
+    ewk_history_clear(history);
+    ewk_history_history_item_add(history, item);
+    ewk_history_history_item_set(history, item);
+    ewk_history_item_free(item);
 }