Changeset 112225 in webkit

Timestamp:

Mar 27, 2012 1:34:19 AM (12 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: HeapSnapshot: speed-up distanceToWindow calculation.
​https://bugs.webkit.org/show_bug.cgi?id=82305

Reviewed by Yury Semikhatsky.

• inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._bfs):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/HeapSnapshot.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: HeapSnapshot: speed-up distanceToWindow calculation.
+        https://bugs.webkit.org/show_bug.cgi?id=82305
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/HeapSnapshot.js:
+        (WebInspector.HeapSnapshot.prototype._bfs):
+
 2012-03-27  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js

@@ -1149 +1149 @@
     {
         var index = 0;
-        var node = this.rootNode;
+        var nodes = this._nodes;
         while (index < list.length) {
             var nodeIndex = list[index++]; // shift generates too much garbage.
@@ -1157 +1157 @@
             }
             var distance = this._distancesToWindow[nodeIndex] + 1;
-            node.nodeIndex = nodeIndex;
-            for (var iter = node.edges; iter.hasNext(); iter.next()) {
-                var childNodeIndex = iter.edge.nodeIndex;
+            var edgesCount = nodes[nodeIndex + this._edgesCountOffset];
+            var edgeToNodeIndex = nodeIndex + this._firstEdgeOffset + this._edgeToNodeOffset;
+            for (var i = 0; i < edgesCount; ++i) {
+                var childNodeIndex = nodes[edgeToNodeIndex];
+                edgeToNodeIndex += this._edgeFieldsCount;
                 if (childNodeIndex in this._distancesToWindow)
                     continue;