Changeset 112268 in webkit

Timestamp:

Mar 27, 2012 7:55:27 AM (12 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: simplify heap profiler front-end
​https://bugs.webkit.org/show_bug.cgi?id=82338

Source/WebCore:

Simplify constructors of WebInspector.HeapSnapshotArraySlice and
WebInspector.HeapSnapshotEdgesProvider.

Reviewed by Pavel Feldman.

• inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotArraySlice):
(WebInspector.HeapSnapshotArraySlice.prototype.item):
(WebInspector.HeapSnapshotArraySlice.prototype.slice):
(WebInspector.HeapSnapshotNode.prototype.get rawEdges):
(WebInspector.HeapSnapshot.prototype._retainersForNode):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):

LayoutTests:

Reviewed by Pavel Feldman.

• inspector/profiler/heap-snapshot.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/profiler/heap-snapshot.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/HeapSnapshot.js (modified) (8 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-27  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: simplify heap profiler front-end
+        https://bugs.webkit.org/show_bug.cgi?id=82338
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/profiler/heap-snapshot.html:
+
 2012-03-27  Pavel Podivilov  <podivilov@chromium.org>
 

trunk/LayoutTests/inspector/profiler/heap-snapshot.html

@@ -217 +217 @@
             }
          
-            var provider = new WebInspector.HeapSnapshotEdgesProvider(snapshot, snapshot.rootNodeIndex, edgeFilter);
+            var provider = snapshot.createEdgesProvider(snapshot.rootNodeIndex, edgeFilter);
             InspectorTest.assertEquals(1, provider.length, "edges provider length");
             provider.sort(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.createComparator(["!edgeName", false, "id", false]), 0, 0, 1);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: simplify heap profiler front-end
+        https://bugs.webkit.org/show_bug.cgi?id=82338
+
+        Simplify constructors of WebInspector.HeapSnapshotArraySlice and
+        WebInspector.HeapSnapshotEdgesProvider.
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/HeapSnapshot.js:
+        (WebInspector.HeapSnapshotArraySlice):
+        (WebInspector.HeapSnapshotArraySlice.prototype.item):
+        (WebInspector.HeapSnapshotArraySlice.prototype.slice):
+        (WebInspector.HeapSnapshotNode.prototype.get rawEdges):
+        (WebInspector.HeapSnapshot.prototype._retainersForNode):
+        (WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
+        (WebInspector.HeapSnapshot.prototype.createEdgesProvider):
+        (WebInspector.HeapSnapshotEdgesProvider):
+
 2012-03-27  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js

@@ -212 +212 @@
 };
 
-WebInspector.HeapSnapshotArraySlice = function(snapshot, arrayName, start, end)
+WebInspector.HeapSnapshotArraySlice = function(array, start, end)
 {
-    // Note: we don't reference snapshot contents directly to avoid
-    // holding references to big chunks of data.
-    this._snapshot = snapshot;
-    this._arrayName = arrayName;
+    this._array = array;
     this._start = start;
     this.length = end - start;
@@ -225 +222 @@
     item: function(index)
     {
-        return this._snapshot[this._arrayName][this._start + index];
+        return this._array[this._start + index];
     },
 
@@ -232 +229 @@
         if (typeof end === "undefined")
             end = this.length;
-        return this._snapshot[this._arrayName].subarray(this._start + start, this._start + end);
+        return this._array.subarray(this._start + start, this._start + end);
     }
 }
@@ -658 +655 @@
     {
         var firstEdgeIndex = this._firstEdgeIndex();
-        return new WebInspector.HeapSnapshotArraySlice(this._snapshot, "_nodes", firstEdgeIndex, firstEdgeIndex + this.edgesCount * this._snapshot._edgeFieldsCount);
+        return new WebInspector.HeapSnapshotArraySlice(this._snapshot._nodes, firstEdgeIndex, firstEdgeIndex + this.edgesCount * this._snapshot._edgeFieldsCount);
     },
 
@@ -987 +984 @@
         var retIndexFrom = this._getRetainerIndex(node.nodeIndex);
         var retIndexTo = this._getRetainerIndex(node._nextNodeIndex);
-        return new WebInspector.HeapSnapshotArraySlice(this, "_retainers", retIndexFrom, retIndexTo);
+        return new WebInspector.HeapSnapshotArraySlice(this._retainers, retIndexFrom, retIndexTo);
     },
 
@@ -994 +991 @@
         var dominatedIndexFrom = this._getDominatedIndex(node.nodeIndex);
         var dominatedIndexTo = this._getDominatedIndex(node._nextNodeIndex);
-        return new WebInspector.HeapSnapshotArraySlice(this, "_dominatedNodes", dominatedIndexFrom, dominatedIndexTo);
+        return new WebInspector.HeapSnapshotArraySlice(this._dominatedNodes, dominatedIndexFrom, dominatedIndexTo);
     },
 
@@ -1448 +1445 @@
     createEdgesProvider: function(nodeIndex, filter)
     {
-        return new WebInspector.HeapSnapshotEdgesProvider(this, nodeIndex, this._parseFilter(filter));
+        var node = new WebInspector.HeapSnapshotNode(this, nodeIndex);
+        return new WebInspector.HeapSnapshotEdgesProvider(this, nodeIndex, this._parseFilter(filter), node.edges);
     },
 
@@ -1605 +1603 @@
 }
 
-WebInspector.HeapSnapshotEdgesProvider = function(snapshot, nodeIndex, filter, iter)
+WebInspector.HeapSnapshotEdgesProvider = function(snapshot, nodeIndex, filter, edgesIter)
 {
     this.snapshot = snapshot;
-    var node = new WebInspector.HeapSnapshotNode(snapshot, nodeIndex);
-    var edgesIter = iter || new WebInspector.HeapSnapshotEdgeIterator(new WebInspector.HeapSnapshotEdge(snapshot, node.rawEdges));
     WebInspector.HeapSnapshotFilteredOrderedIterator.call(this, edgesIter, filter);
 }