Changeset 112385 in webkit

Timestamp:

Mar 28, 2012 5:31:20 AM (12 years ago)

Author:

leo.yang@torchmobile.com.cn

Message:

[BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
​https://bugs.webkit.org/show_bug.cgi?id=82420

Reviewed by Rob Buis.

In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet)
for PlatformMouseEvent, but this method is same as globalPosition() that is available for
every porting. We should use globalPosition().

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateCursor):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPage.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -2167 +2167 @@
         buttonMask = Platform::MouseEvent::ScreenRightMouseButton;
 
-    BlackBerry::Platform::MouseEvent event(buttonMask, buttonMask, mapToTransformed(m_lastMouseEvent.position()), mapToTransformed(m_lastMouseEvent.globalPos()), 0, 0);
+    BlackBerry::Platform::MouseEvent event(buttonMask, buttonMask, mapToTransformed(m_lastMouseEvent.position()), mapToTransformed(m_lastMouseEvent.globalPosition()), 0, 0);
     m_webPage->mouseEvent(event);
 }

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-03-28  Leo Yang  <leo.yang@torchmobile.com.cn>
+
+        [BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=82420
+
+        Reviewed by Rob Buis.
+
+        In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet)
+        for PlatformMouseEvent, but this method is same as globalPosition() that is available for
+        every porting. We should use globalPosition().
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::updateCursor):
+
 2012-03-27  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>