Changeset 112401 in webkit

Timestamp:

Mar 28, 2012 8:13:51 AM (12 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Implement PlatformStrategies
​https://bugs.webkit.org/show_bug.cgi?id=82454

Reviewed by Xan Lopez.

Source/WebCore:

• GNUmakefile.list.am: Remove PluginDataGtk.cpp. The same

functionality is now implemented using platform strategies.

• plugins/gtk/PluginDataGtk.cpp: Removed.

Source/WebKit/gtk:

• GNUmakefile.am: Add new files to compilation.
• WebCoreSupport/PlatformStrategiesGtk.cpp: Added.

(PlatformStrategiesGtk::initialize): Initialize platform
strategies.
(PlatformStrategiesGtk::PlatformStrategiesGtk):
(PlatformStrategiesGtk::createCookiesStrategy): Return this.
(PlatformStrategiesGtk::createPluginStrategy): Ditto.
(PlatformStrategiesGtk::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesGtk::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesGtk::notifyCookiesChanged):
(PlatformStrategiesGtk::refreshPlugins): Refresh the plugin
database.
(PlatformStrategiesGtk::getPluginInfo): Initialize plugins and
populate the given vector with plugins information.
(PlatformStrategiesGtk::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesGtk::addVisitedLink): Add the given hash to the
page group visited links.

• WebCoreSupport/PlatformStrategiesGtk.h: Added.
• webkit/webkitglobals.cpp:

(webkitInit): Initialize PlatformStrategiesGtk.

Source/WTF:

• wtf/Platform.h: Define WTF_USE_PLATFORM_STRATEGIES for GTK+

platform too.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/Platform.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/GNUmakefile.list.am (modified) (6 diffs)
• WebCore/plugins/gtk/PluginDataGtk.cpp (deleted)
• WebKit/gtk/ChangeLog (modified) (1 diff)
• WebKit/gtk/GNUmakefile.am (modified) (1 diff)
• WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp (added)
• WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h (added)
• WebKit/gtk/webkit/webkitglobals.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Implement PlatformStrategies
+        https://bugs.webkit.org/show_bug.cgi?id=82454
+
+        Reviewed by Xan Lopez.
+
+        * wtf/Platform.h: Define WTF_USE_PLATFORM_STRATEGIES for GTK+
+        platform too.
+
 2012-03-26  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WTF/wtf/Platform.h

@@ -1098 +1098 @@
 
 /* FIXME: Eventually we should enable this for all platforms and get rid of the define. */
-#if PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(QT)
+#if PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(QT) || PLATFORM(GTK)
 #define WTF_USE_PLATFORM_STRATEGIES 1
 #endif

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Implement PlatformStrategies
+        https://bugs.webkit.org/show_bug.cgi?id=82454
+
+        Reviewed by Xan Lopez.
+
+        * GNUmakefile.list.am: Remove PluginDataGtk.cpp. The same
+        functionality is now implemented using platform strategies.
+        * plugins/gtk/PluginDataGtk.cpp: Removed.
+
 2012-03-28  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/GNUmakefile.list.am

@@ -3036 +3036 @@
         Source/WebCore/platform/ContextMenuItem.h \
         Source/WebCore/platform/Cookie.h \
+        Source/WebCore/platform/CookiesStrategy.h \
         Source/WebCore/platform/CookieJar.h \
         Source/WebCore/platform/CrossThreadCopier.cpp \
@@ -3463 +3464 @@
         Source/WebCore/platform/NotImplemented.h \
         Source/WebCore/platform/Pasteboard.h \
+        Source/WebCore/platform/PasteboardStrategy.h \
         Source/WebCore/platform/PlatformEvent.cpp \
         Source/WebCore/platform/PlatformEvent.h \
@@ -3472 +3474 @@
         Source/WebCore/platform/PlatformMouseEvent.h \
         Source/WebCore/platform/PlatformScreen.h \
+        Source/WebCore/platform/PlatformStrategies.cpp \
+        Source/WebCore/platform/PlatformStrategies.h \
         Source/WebCore/platform/PlatformWheelEvent.h \
         Source/WebCore/platform/PODArena.h \
@@ -3601 +3605 @@
         Source/WebCore/platform/UUID.cpp \
         Source/WebCore/platform/UUID.h \
+        Source/WebCore/platform/VisitedLinkStrategy.h \
         Source/WebCore/platform/Widget.cpp \
         Source/WebCore/platform/Widget.h \
@@ -3628 +3633 @@
         Source/WebCore/plugins/PluginPackage.h \
         Source/WebCore/plugins/PluginQuirkSet.h \
+        Source/WebCore/plugins/PluginStrategy.h \
         Source/WebCore/plugins/PluginStream.cpp \
         Source/WebCore/plugins/PluginStream.h \
@@ -3633 +3639 @@
         Source/WebCore/plugins/PluginView.cpp \
         Source/WebCore/plugins/PluginView.h \
-        Source/WebCore/plugins/gtk/PluginDataGtk.cpp \
         Source/WebCore/rendering/AutoTableLayout.cpp \
         Source/WebCore/rendering/AutoTableLayout.h \

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Implement PlatformStrategies
+        https://bugs.webkit.org/show_bug.cgi?id=82454
+
+        Reviewed by Xan Lopez.
+
+        * GNUmakefile.am: Add new files to compilation.
+        * WebCoreSupport/PlatformStrategiesGtk.cpp: Added.
+        (PlatformStrategiesGtk::initialize): Initialize platform
+        strategies.
+        (PlatformStrategiesGtk::PlatformStrategiesGtk):
+        (PlatformStrategiesGtk::createCookiesStrategy): Return this.
+        (PlatformStrategiesGtk::createPluginStrategy): Ditto.
+        (PlatformStrategiesGtk::createVisitedLinkStrategy): Ditto.
+        (PlatformStrategiesGtk::createPasteboardStrategy): Return 0, since
+        PasteboardStrategy is only used by mac code for now.
+        (PlatformStrategiesGtk::notifyCookiesChanged):
+        (PlatformStrategiesGtk::refreshPlugins): Refresh the plugin
+        database.
+        (PlatformStrategiesGtk::getPluginInfo): Initialize plugins and
+        populate the given vector with plugins information.
+        (PlatformStrategiesGtk::isLinkVisited): Return whether the given
+        hash is a visited link of the page group.
+        (PlatformStrategiesGtk::addVisitedLink): Add the given hash to the
+        page group visited links.
+        * WebCoreSupport/PlatformStrategiesGtk.h: Added.
+        * webkit/webkitglobals.cpp:
+        (webkitInit): Initialize PlatformStrategiesGtk.
+
 2012-03-26  Joone Hur  <joone.hur@collabora.co.uk>
 

trunk/Source/WebKit/gtk/GNUmakefile.am

@@ -212 +212 @@
         Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h \
         Source/WebKit/gtk/WebCoreSupport/PasteboardHelperGtk.h \
+        Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h \
+        Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp \
         Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.cpp \
         Source/WebKit/gtk/WebCoreSupport/UserMediaClientGtk.h \

trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp

@@ -33 +33 @@
 #include "PageCache.h"
 #include "PageGroup.h"
+#include "PlatformStrategiesGtk.h"
 #include "TextEncodingRegistry.h"
 #include "Pasteboard.h"
@@ -501 +502 @@
 
     WebCore::initializeLoggingChannelsIfNecessary();
+    PlatformStrategiesGtk::initialize();
 
     // We make sure the text codecs have been initialized, because