Changeset 112493 in webkit


Ignore:
Timestamp:
Mar 28, 2012 7:18:18 PM (12 years ago)
Author:
noel.gordon@gmail.com
Message:

JPEGImageDecoder: Set frame alpha state before marking a frame complete
https://bugs.webkit.org/show_bug.cgi?id=82428

Reviewed by Kenneth Russell.

r109779 changed JPEG alpha channel handling by marking a JPEG image frame
as having no alpha _after_ setting the image status frame-complete, which
prevents the application of image color profiles in some WebGL cases.

No new tests. The application of the color profile is not guaranteed for
images used as textures in WebGL. Refer to http://wkb.ug/76498.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::jpegComplete): Set the image frame alpha state
before marking the image frame status as frame-complete.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r112492 r112493  
     12012-03-28  Noel Gordon  <noel.gordon@gmail.com>
     2
     3        JPEGImageDecoder: Set frame alpha state before marking a frame complete
     4        https://bugs.webkit.org/show_bug.cgi?id=82428
     5
     6        Reviewed by Kenneth Russell.
     7
     8        r109779 changed JPEG alpha channel handling by marking a JPEG image frame
     9        as having no alpha _after_ setting the image status frame-complete, which
     10        prevents the application of image color profiles in some WebGL cases.
     11
     12        No new tests. The application of the color profile is not guaranteed for
     13        images used as textures in WebGL. Refer to http://wkb.ug/76498.
     14
     15        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
     16        (WebCore::JPEGImageDecoder::jpegComplete): Set the image frame alpha state
     17        before marking the image frame status as frame-complete.
     18
    1192012-03-28  Emil A Eklund  <eae@chromium.org>
    220
  • trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

    r109779 r112493  
    573573    // empty.
    574574    ImageFrame& buffer = m_frameBufferCache[0];
     575    buffer.setHasAlpha(false);
    575576    buffer.setStatus(ImageFrame::FrameComplete);
    576     buffer.setHasAlpha(false);
    577577}
    578578
Note: See TracChangeset for help on using the changeset viewer.