Changeset 112501 in webkit


Ignore:
Timestamp:
Mar 28, 2012 10:29:47 PM (12 years ago)
Author:
abarth@webkit.org
Message:

[Chromium] Move APIs related to ResourceHandle into Platform
​https://bugs.webkit.org/show_bug.cgi?id=82553

Reviewed by James Robinson.

Source/Platform:

This patch is the first patch in this series:
​https://github.com/abarth/webkit/compare/master...webcore-platform

The goal of these patches is to move WebCore::ResourceHandle out of
Chromium's WebKit layer and into WebCore/platform, where it belongs.

This patch moves the Chromium-WebKit APIs used by ResourceHandle out of
the WebKit layer and into the Plaform layer. These are APIs that WebKit
uses to call "down" to manipulate the underlying platform (rather than
"up" to the client to make decisions). The long-term plan is to move
all of the headers in WebKit/chromium/public/platform into
Platform/chromium/public (although we'll likely need to clean up some
layering violations as we go).

  • Platform.gypi:
  • chromium/public/WebData.h: Added.

(WebKit):
(WebData):
(WebKit::WebData::~WebData):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
(WebKit::WebData::isEmpty):
(WebKit::WebData::isNull):

  • chromium/public/WebHTTPBody.h: Added.

(WebKit):
(WebHTTPBody):
(WebKit::WebHTTPBody::~WebHTTPBody):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::isNull):

  • chromium/public/WebHTTPHeaderVisitor.h: Added.

(WebKit):
(WebHTTPHeaderVisitor):
(WebKit::WebHTTPHeaderVisitor::~WebHTTPHeaderVisitor):

  • chromium/public/WebHTTPLoadInfo.h: Added.

(WebCore):
(WebKit):
(WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::operator =):

  • chromium/public/WebPrivateOwnPtr.h: Added.

(WebKit):
(WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::reset):
(WebKit::WebPrivateOwnPtr::get):
(WebKit::WebPrivateOwnPtr::operator->):

  • chromium/public/WebURL.h: Added.

(WebKit):
(WebURL):
(WebKit::WebURL::~WebURL):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::operator=):
(WebKit::WebURL::assign):
(WebKit::WebURL::spec):
(WebKit::WebURL::parsed):
(WebKit::WebURL::isValid):
(WebKit::WebURL::isEmpty):
(WebKit::WebURL::isNull):
(WebKit::WebURL::operator GURL):
(WebKit::operator<):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebURLError.h: Added.

(WebKit):
(WebURLError):
(WebKit::WebURLError::WebURLError):

  • chromium/public/WebURLLoadTiming.h: Added.

(WebKit):
(WebURLLoadTiming):
(WebKit::WebURLLoadTiming::~WebURLLoadTiming):
(WebKit::WebURLLoadTiming::WebURLLoadTiming):
(WebKit::WebURLLoadTiming::operator=):
(WebKit::WebURLLoadTiming::isNull):

  • chromium/public/WebURLLoader.h: Added.

(WebKit):
(WebURLLoader):
(WebKit::WebURLLoader::~WebURLLoader):

  • chromium/public/WebURLLoaderClient.h: Added.

(WebKit):
(WebURLLoaderClient):
(WebKit::WebURLLoaderClient::willSendRequest):
(WebKit::WebURLLoaderClient::didSendData):
(WebKit::WebURLLoaderClient::didReceiveResponse):
(WebKit::WebURLLoaderClient::didDownloadData):
(WebKit::WebURLLoaderClient::didReceiveData):
(WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
(WebKit::WebURLLoaderClient::didFinishLoading):
(WebKit::WebURLLoaderClient::didFail):
(WebKit::WebURLLoaderClient::~WebURLLoaderClient):

  • chromium/public/WebURLRequest.h: Added.

(WebKit):
(WebURLRequest):
(ExtraData):
(WebKit::WebURLRequest::ExtraData::~ExtraData):
(WebKit::WebURLRequest::~WebURLRequest):
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::operator=):

  • chromium/public/WebURLResponse.h: Added.

(WebKit):
(WebURLResponse):
(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebKit::WebURLResponse::~WebURLResponse):
(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::operator=):

Source/WebKit/chromium:

These headers are now just forwarding headers to the new location of
these headers. These forwarding headers exist to avoid breaking
existing users of the API. They will likely be removed (or changed)
in the future once we've updated all folks using them.

  • public/platform/WebData.h:
  • public/platform/WebHTTPBody.h:
  • public/platform/WebHTTPHeaderVisitor.h:
  • public/platform/WebHTTPLoadInfo.h:
  • public/platform/WebPrivateOwnPtr.h:
  • public/platform/WebURL.h:
  • public/platform/WebURLError.h:
  • public/platform/WebURLLoadTiming.h:
  • public/platform/WebURLLoader.h:
  • public/platform/WebURLLoaderClient.h:
  • public/platform/WebURLRequest.h:
  • public/platform/WebURLResponse.h:
Location:
trunk/Source
Files:
12 added
3 edited
12 copied

Legend:

Unmodified
Added
Removed

  • trunk/Source/Platform/ChangeLog

    r112360 r112501  
     12012-03-28  Adam Barth  <abarth@webkit.org>
     2
     3        [Chromium] Move APIs related to ResourceHandle into Platform
     4        https://bugs.webkit.org/show_bug.cgi?id=82553
     5
     6        Reviewed by James Robinson.
     7
     8        This patch is the first patch in this series:
     9        https://github.com/abarth/webkit/compare/master...webcore-platform
     10
     11        The goal of these patches is to move WebCore::ResourceHandle out of
     12        Chromium's WebKit layer and into WebCore/platform, where it belongs.
     13
     14        This patch moves the Chromium-WebKit APIs used by ResourceHandle out of
     15        the WebKit layer and into the Plaform layer. These are APIs that WebKit
     16        uses to call "down" to manipulate the underlying platform (rather than
     17        "up" to the client to make decisions). The long-term plan is to move
     18        all of the headers in WebKit/chromium/public/platform into
     19        Platform/chromium/public (although we'll likely need to clean up some
     20        layering violations as we go).
     21
     22        * Platform.gypi:
     23        * chromium/public/WebData.h: Added.
     24        (WebKit):
     25        (WebData):
     26        (WebKit::WebData::~WebData):
     27        (WebKit::WebData::WebData):
     28        (WebKit::WebData::operator=):
     29        (WebKit::WebData::isEmpty):
     30        (WebKit::WebData::isNull):
     31        * chromium/public/WebHTTPBody.h: Added.
     32        (WebKit):
     33        (WebHTTPBody):
     34        (WebKit::WebHTTPBody::~WebHTTPBody):
     35        (WebKit::WebHTTPBody::WebHTTPBody):
     36        (WebKit::WebHTTPBody::operator=):
     37        (WebKit::WebHTTPBody::isNull):
     38        * chromium/public/WebHTTPHeaderVisitor.h: Added.
     39        (WebKit):
     40        (WebHTTPHeaderVisitor):
     41        (WebKit::WebHTTPHeaderVisitor::~WebHTTPHeaderVisitor):
     42        * chromium/public/WebHTTPLoadInfo.h: Added.
     43        (WebCore):
     44        (WebKit):
     45        (WebHTTPLoadInfo):
     46        (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
     47        (WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo):
     48        (WebKit::WebHTTPLoadInfo::operator =):
     49        * chromium/public/WebPrivateOwnPtr.h: Added.
     50        (WebKit):
     51        (WebPrivateOwnPtr):
     52        (WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr):
     53        (WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr):
     54        (WebKit::WebPrivateOwnPtr::reset):
     55        (WebKit::WebPrivateOwnPtr::get):
     56        (WebKit::WebPrivateOwnPtr::operator->):
     57        * chromium/public/WebURL.h: Added.
     58        (WebKit):
     59        (WebURL):
     60        (WebKit::WebURL::~WebURL):
     61        (WebKit::WebURL::WebURL):
     62        (WebKit::WebURL::operator=):
     63        (WebKit::WebURL::assign):
     64        (WebKit::WebURL::spec):
     65        (WebKit::WebURL::parsed):
     66        (WebKit::WebURL::isValid):
     67        (WebKit::WebURL::isEmpty):
     68        (WebKit::WebURL::isNull):
     69        (WebKit::WebURL::operator GURL):
     70        (WebKit::operator<):
     71        (WebKit::operator==):
     72        (WebKit::operator!=):
     73        * chromium/public/WebURLError.h: Added.
     74        (WebKit):
     75        (WebURLError):
     76        (WebKit::WebURLError::WebURLError):
     77        * chromium/public/WebURLLoadTiming.h: Added.
     78        (WebKit):
     79        (WebURLLoadTiming):
     80        (WebKit::WebURLLoadTiming::~WebURLLoadTiming):
     81        (WebKit::WebURLLoadTiming::WebURLLoadTiming):
     82        (WebKit::WebURLLoadTiming::operator=):
     83        (WebKit::WebURLLoadTiming::isNull):
     84        * chromium/public/WebURLLoader.h: Added.
     85        (WebKit):
     86        (WebURLLoader):
     87        (WebKit::WebURLLoader::~WebURLLoader):
     88        * chromium/public/WebURLLoaderClient.h: Added.
     89        (WebKit):
     90        (WebURLLoaderClient):
     91        (WebKit::WebURLLoaderClient::willSendRequest):
     92        (WebKit::WebURLLoaderClient::didSendData):
     93        (WebKit::WebURLLoaderClient::didReceiveResponse):
     94        (WebKit::WebURLLoaderClient::didDownloadData):
     95        (WebKit::WebURLLoaderClient::didReceiveData):
     96        (WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
     97        (WebKit::WebURLLoaderClient::didFinishLoading):
     98        (WebKit::WebURLLoaderClient::didFail):
     99        (WebKit::WebURLLoaderClient::~WebURLLoaderClient):
     100        * chromium/public/WebURLRequest.h: Added.
     101        (WebKit):
     102        (WebURLRequest):
     103        (ExtraData):
     104        (WebKit::WebURLRequest::ExtraData::~ExtraData):
     105        (WebKit::WebURLRequest::~WebURLRequest):
     106        (WebKit::WebURLRequest::WebURLRequest):
     107        (WebKit::WebURLRequest::operator=):
     108        * chromium/public/WebURLResponse.h: Added.
     109        (WebKit):
     110        (WebURLResponse):
     111        (ExtraData):
     112        (WebKit::WebURLResponse::ExtraData::~ExtraData):
     113        (WebKit::WebURLResponse::~WebURLResponse):
     114        (WebKit::WebURLResponse::WebURLResponse):
     115        (WebKit::WebURLResponse::operator=):
     116
    11172012-03-27  Nat Duca  <nduca@chromium.org>
    2118

  • trunk/Source/Platform/Platform.gypi

    r108877 r112501  
    3838            'chromium/public/WebContentLayer.h',
    3939            'chromium/public/WebContentLayerClient.h',
     40            'chromium/public/WebData.h',
    4041            'chromium/public/WebExternalTextureLayer.h',
    4142            'chromium/public/WebFloatPoint.h',
    … …  
    4344            'chromium/public/WebFloatRect.h',
    4445            'chromium/public/WebGraphicsContext3D.h',
     46            'chromium/public/WebHTTPBody.h',
     47            'chromium/public/WebHTTPHeaderVisitor.h',
     48            'chromium/public/WebHTTPLoadInfo.h',
    4549            'chromium/public/WebLayer.h',
    4650            'chromium/public/WebLayerTreeView.h',
    … …  
    4953            'chromium/public/WebNonCopyable.h',
    5054            'chromium/public/WebPoint.h',
     55            'chromium/public/WebPrivateOwnPtr.h',
    5156            'chromium/public/WebPrivatePtr.h',
    5257            'chromium/public/WebRect.h',
    … …  
    5459            'chromium/public/WebSolidColorLayer.h',
    5560            'chromium/public/WebString.h',
     61            'chromium/public/WebURL.h',
     62            'chromium/public/WebURLError.h',
     63            'chromium/public/WebURLLoadTiming.h',
     64            'chromium/public/WebURLLoader.h',
     65            'chromium/public/WebURLLoaderClient.h',
     66            'chromium/public/WebURLRequest.h',
     67            'chromium/public/WebURLResponse.h',
    5668            'chromium/src/WebCString.cpp',
    5769            'chromium/src/WebFloatQuad.cpp',

  • trunk/Source/WebKit/chromium/ChangeLog

    r112485 r112501  
     12012-03-28  Adam Barth  <abarth@webkit.org>
     2
     3        [Chromium] Move APIs related to ResourceHandle into Platform
     4        https://bugs.webkit.org/show_bug.cgi?id=82553
     5
     6        Reviewed by James Robinson.
     7
     8        These headers are now just forwarding headers to the new location of
     9        these headers. These forwarding headers exist to avoid breaking
     10        existing users of the API. They will likely be removed (or changed)
     11        in the future once we've updated all folks using them.
     12
     13        * public/platform/WebData.h:
     14        * public/platform/WebHTTPBody.h:
     15        * public/platform/WebHTTPHeaderVisitor.h:
     16        * public/platform/WebHTTPLoadInfo.h:
     17        * public/platform/WebPrivateOwnPtr.h:
     18        * public/platform/WebURL.h:
     19        * public/platform/WebURLError.h:
     20        * public/platform/WebURLLoadTiming.h:
     21        * public/platform/WebURLLoader.h:
     22        * public/platform/WebURLLoaderClient.h:
     23        * public/platform/WebURLRequest.h:
     24        * public/platform/WebURLResponse.h:
     25
    1262012-03-28  Bill Budge  <bbudge@chromium.org>
    227
Note: See TracChangeset for help on using the changeset viewer.