Changeset 113082 in webkit

Timestamp:

Apr 3, 2012 1:40:36 PM (12 years ago)

Author:

msaboff@apple.com

Message:

Frequent crashes in JSC::parse in a worker thread when running regression tests
​https://bugs.webkit.org/show_bug.cgi?id=82660

Reviewed by Geoffrey Garen.

Source/WebCore:

Initialize m_script to empty string. Therefore if there isn't any script payload,
the worker thread will see an empty string, not a null string.

Re-enabling fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html tests as part of this patch.

• workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::WorkerScriptLoader):

LayoutTests:

Re-enable fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html with corresponding fix.

• platform/mac/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/workers/WorkerScriptLoader.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-04-03  Michael Saboff  <msaboff@apple.com>
+
+        Frequent crashes in JSC::parse in a worker thread when running regression tests
+        https://bugs.webkit.org/show_bug.cgi?id=82660
+
+        Reviewed by Geoffrey Garen.
+
+        Re-enable fast/workers/empty-worker-nocrash.html and 
+        fast/workers/shared-worker-constructor.html with corresponding fix.
+
+        * platform/mac/Skipped:
+
 2012-04-02  Robert Hogan  <robert@webkit.org>
 

trunk/LayoutTests/platform/mac/Skipped

@@ -646 +646 @@
 editing/spelling/spellcheck-async-mutation.html
 
-# Remove from the skipped list when https://bugs.webkit.org/show_bug.cgi?id=82660 is fixed.
-fast/workers/empty-worker-nocrash.html
-fast/workers/shared-worker-constructor.html
-
 # This should only be a layer change.
 # http://webkit.org/b/82129

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-03  Michael Saboff  <msaboff@apple.com>
+
+        Frequent crashes in JSC::parse in a worker thread when running regression tests
+        https://bugs.webkit.org/show_bug.cgi?id=82660
+
+        Reviewed by Geoffrey Garen.
+
+        Initialize m_script to empty string.  Therefore if there isn't any script payload,
+        the worker thread will see an empty string, not a null string.
+
+        Re-enabling fast/workers/empty-worker-nocrash.html and 
+        fast/workers/shared-worker-constructor.html tests as part of this patch.
+
+        * workers/WorkerScriptLoader.cpp:
+        (WebCore::WorkerScriptLoader::WorkerScriptLoader):
+
 2012-04-03  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/workers/WorkerScriptLoader.cpp

@@ -49 +49 @@
 WorkerScriptLoader::WorkerScriptLoader()
     : m_client(0)
+    , m_script("")
     , m_failed(false)
     , m_identifier(0)