Changeset 114151 in webkit

Timestamp:

Apr 13, 2012 11:26:46 AM (12 years ago)

Author:

scheib@chromium.org

Message:

Unreviewed, rolling out r114140.
​http://trac.webkit.org/changeset/114140
​https://bugs.webkit.org/show_bug.cgi?id=83921

Fails fast/css/image-set-parsing.html test it attempts to
introduce. (Requested by scheib on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

• WebCore.gypi:

Source/WebKit/chromium:

• features.gypi:

LayoutTests:

• platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
• platform/chromium/test_expectations.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/fast/css/image-set-parsing-expected.txt (deleted)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/WebCore.gypi (modified) (4 diffs)
• Source/WebKit/chromium/ChangeLog (modified) (1 diff)
• Source/WebKit/chromium/features.gypi (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r114140.
+        http://trac.webkit.org/changeset/114140
+        https://bugs.webkit.org/show_bug.cgi?id=83921
+
+        Fails fast/css/image-set-parsing.html test it attempts to
+        introduce. (Requested by scheib on #webkit).
+
+        * platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
+        * platform/chromium/test_expectations.txt:
+
 2012-04-13  Dan Bernstein  <mitz@apple.com>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3055 +3055 @@
 BUGWK70066 SKIP : fast/hidpi = TIMEOUT
 
+// CSS image-set support not yet enabled (needs ENABLE_CSS_IMAGE_SET).
+BUGWK81859 SKIP : fast/css/image-set-parsing.html = FAIL
+BUGWK81859 SKIP : fast/css/image-set-parsing-invalid.html = FAIL
+
 // Flaky tests from ~r97647
 BUGWK70298 : fast/images/pdf-as-background.html = FAIL TIMEOUT PASS

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r114140.
+        http://trac.webkit.org/changeset/114140
+        https://bugs.webkit.org/show_bug.cgi?id=83921
+
+        Fails fast/css/image-set-parsing.html test it attempts to
+        introduce. (Requested by scheib on #webkit).
+
+        * WebCore.gypi:
+
 2012-04-13  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/WebCore.gypi

@@ -77 +77 @@
             'css/CSSHelper.h',
             'css/CSSImageGeneratorValue.h',
-            'css/CSSImageSetValue.h',
             'css/CSSImageValue.h',
             'css/CSSLineBoxContainValue.h',
@@ -575 +574 @@
             'rendering/style/StyleBoxData.h',
             'rendering/style/StyleCachedImage.h',
-            'rendering/style/StyleCachedImageSet.h',
             'rendering/style/StyleDashboardRegion.h',
             'rendering/style/StyleDeprecatedFlexibleBoxData.h',
@@ -2419 +2417 @@
             'css/CSSGradientValue.h',
             'css/CSSImageGeneratorValue.cpp',
-            'css/CSSImageSetValue.cpp',
             'css/CSSImageValue.cpp',
             'css/CSSImportRule.cpp',
@@ -4899 +4896 @@
             'rendering/style/StyleBoxData.cpp',
             'rendering/style/StyleCachedImage.cpp',
-            'rendering/style/StyleCachedImageSet.cpp',
             'rendering/style/StyleCachedShader.h',
             'rendering/style/StyleCachedShader.cpp',

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r114140.
+        http://trac.webkit.org/changeset/114140
+        https://bugs.webkit.org/show_bug.cgi?id=83921
+
+        Fails fast/css/image-set-parsing.html test it attempts to
+        introduce. (Requested by scheib on #webkit).
+
+        * features.gypi:
+
 2012-04-13  Rob Flack  <flackr@chromium.org>
 

trunk/Source/WebKit/chromium/features.gypi

@@ -39 +39 @@
       'ENABLE_CHANNEL_MESSAGING=1',
       'ENABLE_CSS_FILTERS=1',
-      'ENABLE_CSS_IMAGE_SET=1',
       'ENABLE_CSS_SHADERS=1',
       'ENABLE_DASHBOARD_SUPPORT=0',