Changeset 114211 in webkit

Timestamp:

Apr 14, 2012 8:51:21 PM (12 years ago)

Author:

eae@chromium.org

Message:

Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
​https://bugs.webkit.org/show_bug.cgi?id=83929

Reviewed by Eric Seidel.

Update CalendarPickerElement and MediaControlElements to use
pixelSnappedSize in preparation for turning on subpixel support.
Update RenderScrollbarPart to pixel snap rect before painting to ensure
that it is painted on device pixel boundaries.

No new tests, no change in functionality.

• html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup):

• html/shadow/MediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::layout):

• rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/shadow/CalendarPickerElement.cpp (modified) (1 diff)
• html/shadow/MediaControlElements.cpp (modified) (1 diff)
• rendering/RenderScrollbarPart.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-14  Emil A Eklund  <eae@chromium.org>
+
+        Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
+        https://bugs.webkit.org/show_bug.cgi?id=83929
+
+        Reviewed by Eric Seidel.
+
+        Update CalendarPickerElement and MediaControlElements to use
+        pixelSnappedSize in preparation for turning on subpixel support.
+        Update RenderScrollbarPart to pixel snap rect before painting to ensure
+        that it is painted on device pixel boundaries.
+
+        No new tests, no change in functionality.
+
+        * html/shadow/CalendarPickerElement.cpp:
+        (WebCore::CalendarPickerElement::openPopup):
+        * html/shadow/MediaControlElements.cpp:
+        (WebCore::RenderMediaVolumeSliderContainer::layout):
+        * rendering/RenderScrollbarPart.cpp:
+        (WebCore::RenderScrollbarPart::paintIntoRect):
+
 2012-04-14  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp

@@ -104 +104 @@
     if (!document()->view())
         return;
-    IntRect elementRectInRootView = document()->view()->contentsToRootView(hostInput()->getRect());
+    IntRect elementRectInRootView = document()->view()->contentsToRootView(hostInput()->getPixelSnappedRect());
     m_popup = chrome->client()->openPagePopup(this, elementRectInRootView);
 }

trunk/Source/WebCore/html/shadow/MediaControlElements.cpp

@@ -343 +343 @@
     LayoutStateDisabler layoutStateDisabler(view());
 
-    LayoutPoint offset = theme()->volumeSliderOffsetFromMuteButton(buttonBox, size());
+    IntPoint offset = theme()->volumeSliderOffsetFromMuteButton(buttonBox, pixelSnappedSize());
     setX(offset.x() + buttonBox->offsetLeft());
     setY(offset.y() + buttonBox->offsetTop());

trunk/Source/WebCore/rendering/RenderScrollbarPart.cpp

@@ -173 +173 @@
 
     // Now do the paint.
-    PaintInfo paintInfo(graphicsContext, rect, PaintPhaseBlockBackground, false, 0, 0, 0);
+    PaintInfo paintInfo(graphicsContext, pixelSnappedIntRect(rect), PaintPhaseBlockBackground, false, 0, 0, 0);
     paint(paintInfo, paintOffset);
     paintInfo.phase = PaintPhaseChildBlockBackgrounds;