Changeset 116073 in webkit

Timestamp:

May 3, 2012 11:59:45 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] DRT should obey layoutTestController's addURLToRedirect()
​https://bugs.webkit.org/show_bug.cgi?id=82722

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-03
Reviewed by Maciej Stachowiak.

Tools:

Implement support for layoutTestController's addURLToRedirect()
in EFL's DRT so that it redirects properly when indicated.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now
that EFL's DRT obeys layoutTestController's addURLToRedirect().

• platform/efl/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] DRT should obey layoutTestController's addURLToRedirect()
+        https://bugs.webkit.org/show_bug.cgi?id=82722
+
+        Reviewed by Maciej Stachowiak.
+
+        Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now
+        that EFL's DRT obeys layoutTestController's addURLToRedirect().
+
+        * platform/efl/Skipped:
+
 2012-05-03  Ilya Sherman  <isherman@chromium.org>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -575 +575 @@
 # BUG: Captions support needed in the media engine (via GTK+)
 media/media-captions.html
-
-# BUG: DRT does not obey layoutTestController.addURLToRedirect()
-http/tests/loading/cross-origin-XHR-willLoadRequest.html
 
 # BUG: Requires willPerformClientRedirectToURL

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] DRT should obey layoutTestController's addURLToRedirect()
+        https://bugs.webkit.org/show_bug.cgi?id=82722
+
+        Reviewed by Maciej Stachowiak.
+
+        Implement support for layoutTestController's addURLToRedirect()
+        in EFL's DRT so that it redirects properly when indicated.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::onWillSendRequest):
+
 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -458 +458 @@
         printf("Blocked access to external URL %s\n", messages->request->url);
         messages->request->url = 0;
-    }
+        return;
+    }
+
+    const std::string& destination = gLayoutTestController->redirectionDestinationForURL(url.string().utf8().data());
+    if (destination.length())
+        messages->request->url = strdup(destination.c_str());
 }