Changeset 116088 in webkit

Timestamp:

May 4, 2012 6:16:56 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r116008) old-run-webkit-tests broken
​https://bugs.webkit.org/show_bug.cgi?id=85597

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-04
Reviewed by Simon Hausmann.

Reinstate libraryContainsSymbol.

• Scripts/webkitperl/features.pm:

(libraryContainsSymbol):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitperl/features.pm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-04  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
+
+        REGRESSION(r116008) old-run-webkit-tests broken
+        https://bugs.webkit.org/show_bug.cgi?id=85597
+
+        Reviewed by Simon Hausmann.
+
+        Reinstate libraryContainsSymbol.
+
+        * Scripts/webkitperl/features.pm:
+        (libraryContainsSymbol):
+
 2012-05-04  Zoltan Horvath  <zoltan@webkit.org>
 

trunk/Tools/Scripts/webkitperl/features.pm

@@ -46 +46 @@
 }
 
+sub libraryContainsSymbol($$)
+{
+    my ($path, $symbol) = @_;
+
+    if (isCygwin() or isWindows()) {
+        # FIXME: Implement this for Windows.
+        return 0;
+    }
+
+    my $foundSymbol = 0;
+    if (-e $path) {
+        open NM, "-|", nmPath(), $path or die;
+        while (<NM>) {
+            $foundSymbol = 1 if /$symbol/; # FIXME: This should probably check for word boundaries before/after the symbol name.
+        }
+        close NM;
+    }
+    return $foundSymbol;
+}
+
 sub hasFeature($$)
 {