Changeset 116146 in webkit


Ignore:
Timestamp:
May 4, 2012 12:45:03 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
​https://bugs.webkit.org/show_bug.cgi?id=85134

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add support for setDefersLoading in DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setDefersLoading):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Add missing implementation setDefersLoading and goBack to GTK's
LayoutTestController so that the test case rely on these methods
can be enabled.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::goBack):
(LayoutTestController::setDefersLoading):

LayoutTests:

Unskip loader/navigation-while-deferring-loads.html and disable
loader/load-defer-resume-crash.html as it triggers an assertion
failure.

  • platform/gtk/test_expectations.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r116143 r116146  
     12012-05-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
     2
     3        [GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
     4        https://bugs.webkit.org/show_bug.cgi?id=85134
     5
     6        Reviewed by Martin Robinson.
     7
     8        Unskip loader/navigation-while-deferring-loads.html and disable
     9        loader/load-defer-resume-crash.html as it triggers an assertion
     10        failure.
     11
     12        * platform/gtk/test_expectations.txt:
     13
    1142012-05-04  Andy Estes  <aestes@apple.com>
    215

  • trunk/LayoutTests/platform/gtk/test_expectations.txt

    r116133 r116146  
    11281128BUGWK60206 : http/tests/navigation/response204.html = FAIL
    11291129
    1130 // Unskip after implementing LayoutTestController::setDefersLoading and ::goBack.
    1131 BUGWKGTK : loader/navigation-while-deferring-loads.html = FAIL
    1132 
    11331130BUGWK61118 : fullscreen/full-screen-keyboard-enabled.html = FAIL
    11341131BUGWK61118 : fullscreen/full-screen-element-stack.html = FAIL

  • trunk/Source/WebKit/gtk/ChangeLog

    r116135 r116146  
     12012-05-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
     2
     3        [GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
     4        https://bugs.webkit.org/show_bug.cgi?id=85134
     5
     6        Reviewed by Martin Robinson.
     7
     8        Add support for setDefersLoading in DumpRenderTreeSupportGtk.
     9
     10        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
     11        (DumpRenderTreeSupportGtk::setDefersLoading):
     12        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
     13        (DumpRenderTreeSupportGtk):
     14
    1152012-05-04  Martin Robinson  <mrobinson@igalia.com>
    216

  • trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

    r115998 r116146  
    610610}
    611611
     612void DumpRenderTreeSupportGtk::setDefersLoading(WebKitWebView* webView, bool defers)
     613{
     614    core(webView)->setDefersLoading(defers);
     615}
     616
    612617void DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled(WebKitWebView* webView, bool enabled)
    613618{

  • trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

    r115621 r116146  
    9494    static void rectangleForSelection(WebKitWebFrame*, cairo_rectangle_int_t*);
    9595    static void scalePageBy(WebKitWebView*, float, float, float);
     96    static void setDefersLoading(WebKitWebView*, bool);
    9697    static void setSmartInsertDeleteEnabled(WebKitWebView*, bool);
    9798

  • trunk/Tools/ChangeLog

    r116134 r116146  
     12012-05-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
     2
     3        [GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
     4        https://bugs.webkit.org/show_bug.cgi?id=85134
     5
     6        Reviewed by Martin Robinson.
     7
     8        Add missing implementation setDefersLoading and goBack to GTK's
     9        LayoutTestController so that the test case rely on these methods
     10        can be enabled.
     11
     12        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     13        (resetDefaultsToConsistentValues):
     14        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     15        (LayoutTestController::goBack):
     16        (LayoutTestController::setDefersLoading):
     17
    1182012-05-04  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
    219

  • trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r114796 r116146  
    450450    DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled(false);
    451451    DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled(webView, true);
     452    DumpRenderTreeSupportGtk::setDefersLoading(webView, false);
    452453
    453454    if (axController)

  • trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r115954 r116146  
    753753void LayoutTestController::goBack()
    754754{
    755     // FIXME: implement to enable loader/navigation-while-deferring-loads.html
    756 }
    757 
    758 void LayoutTestController::setDefersLoading(bool)
    759 {
    760     // FIXME: implement to enable loader/navigation-while-deferring-loads.html
     755    WebKitWebView* webView = webkit_web_frame_get_web_view(mainFrame);
     756    webkit_web_view_go_back(webView);
     757}
     758
     759void LayoutTestController::setDefersLoading(bool defers)
     760{
     761    WebKitWebView* webView = webkit_web_frame_get_web_view(mainFrame);
     762    DumpRenderTreeSupportGtk::setDefersLoading(webView, defers);
    761763}
    762764
Note: See TracChangeset for help on using the changeset viewer.