Changeset 116296 in webkit

Timestamp:

May 7, 2012 4:26:33 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=85609

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-07
Reviewed by Simon Hausmann.

Flakiness was caused by the fact that
media/crash-closing-page-with-media-as-plugin-fallback.html and
media/video-poster-blocked-by-willsendrequest.html use the same PNG
file as poster attribute in the video tag. The PNG file gets cached
when the first test is executed and this somehow causes the second
test to fail.

The flakiness was addressed by clearing the memory and page caches
between tests.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-07  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=85609
+
+        Reviewed by Simon Hausmann.
+
+        Flakiness was caused by the fact that
+        media/crash-closing-page-with-media-as-plugin-fallback.html and
+        media/video-poster-blocked-by-willsendrequest.html use the same PNG
+        file as poster attribute in the video tag. The PNG file gets cached
+        when the first test is executed and this somehow causes the second
+        test to fail. 
+
+        The flakiness was addressed by clearing the memory and page caches
+        between tests.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+
 2012-05-07  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -204 +204 @@
     ewk_settings_web_database_clear();
     ewk_settings_web_database_default_quota_set(5 * 1024 * 1024);
+
+    ewk_settings_memory_cache_clear();
 
     ewk_view_setting_private_browsing_set(mainView(), EINA_FALSE);