Changeset 116305 in webkit

Timestamp:

May 7, 2012 6:38:40 AM (12 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: [TextPrompt] Event listeners and CSS style are not removed on detachment
​https://bugs.webkit.org/show_bug.cgi?id=85789

Reviewed by Yury Semikhatsky.

• inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextPrompt.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-07  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: [TextPrompt] Event listeners and CSS style are not removed on detachment
+        https://bugs.webkit.org/show_bug.cgi?id=85789
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/TextPrompt.js:
+        (WebInspector.TextPrompt.prototype._attachInternal):
+        (WebInspector.TextPrompt.prototype.detach):
+
 2012-05-07  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebCore/inspector/front-end/TextPrompt.js

@@ -113 +113 @@
         this._element.addStyleClass("text-prompt");
         this._element.addEventListener("keydown", this._boundOnKeyDown, false);
-        this._element.addEventListener("selectstart", this._selectStart.bind(this), false);
+        this._element.addEventListener("selectstart", this._boundSelectStart, false);
 
         if (typeof this._suggestBoxClassName === "string")
@@ -126 +126 @@
         this.proxyElement.parentElement.insertBefore(this._element, this.proxyElement);
         this.proxyElement.parentElement.removeChild(this.proxyElement);
+        this._element.removeStyleClass("text-prompt");
+        this._element.removeEventListener("keydown", this._boundOnKeyDown, false);
+        this._element.removeEventListener("selectstart", this._boundSelectStart, false);
         delete this._proxyElement;
         WebInspector.restoreFocusFromElement(this._element);