Changeset 116328 in webkit

Timestamp:

May 7, 2012 11:32:13 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] media/video-seek-past-end-playing.html times out
​https://bugs.webkit.org/show_bug.cgi?id=84858

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-05-07
Reviewed by Philippe Normand.

Source/WebCore:

Removing the intentional state change to PAUSED on didEnd().
My understanding is that the fix works because the additional
state transition to PAUSED was resetting the internal m_seeking state to early,
so that updatePlayState() in HTMLMediaElement was not able to
correctly figure out/recover playstate after seeking.

No new tests, covered by existing media tests, and fixing
video-seek-past-end-playing.html flakiness on GTK, failure on EFL.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

video-seek-past-end-playing.html should work reliably after fix, removing.

• platform/gtk/test_expectations.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• LayoutTests/platform/gtk/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-07  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
+
+        [GTK] media/video-seek-past-end-playing.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=84858
+
+        Reviewed by Philippe Normand.
+
+        video-seek-past-end-playing.html should work reliably after fix, removing.
+
+        * platform/gtk/test_expectations.txt:
+
 2012-05-07  Abhishek Arya  <inferno@chromium.org>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -1170 +1170 @@
 media/video-seek-by-small-increment.html
 media/video-seek-past-end-paused.html
-media/video-seek-past-end-playing.html
 media/video-seekable.html
 media/video-seeking.html

trunk/LayoutTests/platform/gtk/test_expectations.txt

@@ -492 +492 @@
 
 BUGWK84856 : media/media-controller-playback.html = PASS TEXT
-BUGWK84858 : media/video-seek-past-end-playing.html = PASS TEXT
 
 // Sometimes asserts in debug builds (cross-platform problem): https://bugs.webkit.org/show_bug.cgi?id=59801

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-07  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
+
+        [GTK] media/video-seek-past-end-playing.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=84858
+
+        Reviewed by Philippe Normand.
+
+        Removing the intentional state change to PAUSED on didEnd().
+        My understanding is that the fix works because the additional
+        state transition to PAUSED was resetting the internal m_seeking state to early,
+        so that updatePlayState() in HTMLMediaElement was not able to
+        correctly figure out/recover playstate after seeking.
+
+        No new tests, covered by existing media tests, and fixing
+        video-seek-past-end-playing.html flakiness on GTK, failure on EFL.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+
 2012-05-07  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -1369 +1369 @@
     m_isEndReached = true;
 
-    gst_element_set_state(m_playBin, GST_STATE_PAUSED);
-
     timeChanged();
 }