Changeset 116347 in webkit


Ignore:
Timestamp:
May 7, 2012 1:23:07 PM (12 years ago)
Author:
ojan@chromium.org
Message:

When embedding the flakiness dashboard, hide popups when the frame is blurred.
​https://bugs.webkit.org/show_bug.cgi?id=85684

Reviewed by Dirk Pranke.

If you show a popup, then click elsewhere in garden-o-matic, it will now
properly hide it.

  • TestResultServer/static-dashboards/dashboard_base.js:

(showPopup):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(showPopupForBuild):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):

  • TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  • TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
Location:
trunk/Tools
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r116344 r116347  
     12012-05-07  Ojan Vafai  <ojan@chromium.org>
     2
     3        When embedding the flakiness dashboard, hide popups when the frame is blurred.
     4        https://bugs.webkit.org/show_bug.cgi?id=85684
     5
     6        Reviewed by Dirk Pranke.
     7
     8        If you show a popup, then click elsewhere in garden-o-matic, it will now
     9        properly hide it.
     10
     11        * TestResultServer/static-dashboards/dashboard_base.js:
     12        (showPopup):
     13        * TestResultServer/static-dashboards/flakiness_dashboard.js:
     14        (showPopupForBuild):
     15        (generatePageForIndividualTests.if):
     16        (generatePageForIndividualTests):
     17        * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
     18        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
     19        * TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
     20
    1212012-05-07  Ian Vollick  <vollick@chromium.org>
    222

  • trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js

    r116024 r116347  
    806806}
    807807
    808 function showPopup(e, html)
     808function showPopup(target, html)
    809809{
    810810    var popup = $('popup');
    … …  
    818818    popup.innerHTML = html;
    819819
    820     var targetRect = e.target.getBoundingClientRect();
     820    var targetRect = target.getBoundingClientRect();
    821821
    822822    var x = Math.min(targetRect.left - 10, document.documentElement.clientWidth - popup.offsetWidth);

  • trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js

    r116162 r116347  
    10161016
    10171017    html += '</ul>';
    1018     showPopup(e, html);
     1018    showPopup(e.target, html);
    10191019}
    10201020
    … …  
    23392339}
    23402340
     2341if (window != parent)
     2342    window.addEventListener('blur', hidePopup);
     2343
    23412344document.addEventListener('keydown', function(e) {
    23422345    if (e.keyIdentifier == 'U+003F' || e.keyIdentifier == 'U+00BF') {

  • trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js

    r116163 r116347  
    667667    deepEqual(tests, [test3, test1, test2]);
    668668});
     669
     670test('popup', 2, function() {
     671    showPopup(document.body, 'dummy content');
     672    ok(document.querySelector('#popup'));
     673    hidePopup();
     674    ok(!document.querySelector('#popup'));
     675});
Note: See TracChangeset for help on using the changeset viewer.