Changeset 116422 in webkit

Timestamp:

May 8, 2012 7:59:58 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[WK2] Integrate Page Visibility state change and WK2 Suspend/Resume API
​https://bugs.webkit.org/show_bug.cgi?id=85650

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2012-05-08
Reviewed by Kenneth Rohde Christiansen.

This patch uses state changes of the Page Visibility API to trigger the
automatic suspension/resume of animations on the WebPage and its main frame,
in the same fashion of what is used by the Suspend/Resume API of WebKit2.
By telling the WebPage it will move off/on the screen and the FrameView to
hide/show, this patch is suspending/resuming animations (animated painting)
but not timers and other active DOM objects.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setVisibilityState):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (2 diffs)
• WebProcess/WebPage/WebPage.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-05-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
+
+        [WK2] Integrate Page Visibility state change and WK2 Suspend/Resume API
+        https://bugs.webkit.org/show_bug.cgi?id=85650
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        This patch uses state changes of the Page Visibility API to trigger the
+        automatic suspension/resume of animations on the WebPage and its main frame,
+        in the same fashion of what is used by the Suspend/Resume API of WebKit2.
+        By telling the WebPage it will move off/on the screen and the FrameView to
+        hide/show, this patch is suspending/resuming animations (animated painting)
+        but not timers and other active DOM objects.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::setVisibilityState):
+
 2012-05-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -225 +225 @@
     , m_gestureReachedScrollingLimit(false)
 #endif
+#if ENABLE(PAGE_VISIBILITY_API)
+    , m_visibilityState(WebCore::PageVisibilityStateVisible)
+#endif
 {
     ASSERT(m_pageID);
@@ -3158 +3161 @@
     if (!m_page)
         return;
-    m_page->setVisibilityState(static_cast<WebCore::PageVisibilityState>(visibilityState), isInitialState);
+
+    WebCore::PageVisibilityState state = static_cast<WebCore::PageVisibilityState>(visibilityState);
+
+    if (m_visibilityState == state)
+        return;
+
+    FrameView* view = m_page->mainFrame() ? m_page->mainFrame()->view() : 0;
+
+    if (state == WebCore::PageVisibilityStateVisible) {
+        m_page->didMoveOnscreen();
+        if (view)
+            view->show();
+    }
+
+    m_page->setVisibilityState(state, isInitialState);
+    m_visibilityState = state;
+
+    if (state == WebCore::PageVisibilityStateHidden) {
+        m_page->willMoveOffscreen();
+        if (view)
+            view->hide();
+    }
 }
 #endif

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h

@@ -53 +53 @@
 #include <WebCore/FrameLoaderTypes.h>
 #include <WebCore/IntRect.h>
+#if ENABLE(PAGE_VISIBILITY_API)
+#include <WebCore/PageVisibilityState.h>
+#endif
 #include <WebCore/PlatformScreen.h>
 #include <WebCore/ScrollTypes.h>
@@ -829 +832 @@
     HashMap<String, QtNetworkReply*> m_applicationSchemeReplies;
 #endif
+#if ENABLE(PAGE_VISIBILITY_API)
+    WebCore::PageVisibilityState m_visibilityState;
+#endif
 };