Changeset 116434 in webkit

Timestamp:

May 8, 2012 10:14:44 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Memory leak in DRT EventSender.cpp
​https://bugs.webkit.org/show_bug.cgi?id=85886

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-08
Reviewed by Martin Robinson.

Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
JSString created with JSStringCreateWithUTF8CString.

• DumpRenderTree/gtk/EventSender.cpp:

(gdkModifersFromJSValue):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/gtk/EventSender.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-08  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [GTK] Memory leak in DRT EventSender.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=85886
+
+        Reviewed by Martin Robinson.
+
+        Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
+        JSString created with JSStringCreateWithUTF8CString.
+
+        * DumpRenderTree/gtk/EventSender.cpp:
+        (gdkModifersFromJSValue):
+
 2012-05-08  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Tools/DumpRenderTree/gtk/EventSender.cpp

@@ -299 +299 @@
 
     guint gdkModifiers = 0;
-    int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, JSStringCreateWithUTF8CString("length"), 0), 0);
+    JSRetainPtr<JSStringRef> lengthProperty(Adopt, JSStringCreateWithUTF8CString("length"));
+    int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, lengthProperty.get(), 0), 0);
     for (int i = 0; i < modifiersCount; ++i)
         gdkModifiers |= gdkModifierFromJSValue(context, JSObjectGetPropertyAtIndex(context, modifiersArray, i, 0));