Changeset 116452 in webkit


Ignore:
Timestamp:
May 8, 2012 1:24:53 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
​https://bugs.webkit.org/show_bug.cgi?id=85479

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-08
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

EFL's PlatformKeyboardEvent::isKeypad() now returns meaningful value.
Added numeric-pad keys to the Key Map and Windows Key Map.

No new tests.

  • platform/efl/EflKeyboardUtilities.cpp:

(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):

  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

LayoutTests:

Unskipped fast/events/keydown-numpad-keys.html.

  • platform/efl/Skipped:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r116451 r116452  
     12012-05-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
     2
     3        [EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
     4        https://bugs.webkit.org/show_bug.cgi?id=85479
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Unskipped fast/events/keydown-numpad-keys.html.
     9
     10        * platform/efl/Skipped:
     11
    1122012-05-04  Nikolas Zimmermann  <nzimmermann@rim.com>
    213

  • trunk/LayoutTests/platform/efl/Skipped

    r116445 r116452  
    952952fast/events/key-events-in-input-button.html
    953953fast/events/key-events-in-input-text.html
    954 fast/events/keydown-numpad-keys.html
    955954fast/events/option-tab.html
    956955fast/events/special-key-events-in-input-text.html

  • trunk/Source/WebCore/ChangeLog

    r116451 r116452  
     12012-05-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
     2
     3        [EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
     4        https://bugs.webkit.org/show_bug.cgi?id=85479
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        EFL's PlatformKeyboardEvent::isKeypad() now returns meaningful value.
     9        Added numeric-pad keys to the Key Map and Windows Key Map.
     10
     11        No new tests.
     12
     13        * platform/efl/EflKeyboardUtilities.cpp:
     14        (WebCore::createKeyMap):
     15        (WebCore::createWindowsKeyMap):
     16        * platform/efl/PlatformKeyboardEventEfl.cpp:
     17        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
     18
    1192012-05-04  Nikolas Zimmermann  <nzimmermann@rim.com>
    220

  • trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp

    r114721 r116452  
    7979    keyMap().set("BackSpace", "U+0008");
    8080    keyMap().set("space", "U+0020");
     81    // Keypad location
     82    keyMap().set("KP_Left", "Left");
     83    keyMap().set("KP_Right", "Right");
     84    keyMap().set("KP_Up", "Up");
     85    keyMap().set("KP_Down", "Down");
     86    keyMap().set("KP_Prior", "PageUp");
     87    keyMap().set("KP_Next", "PageDown");
     88    keyMap().set("KP_Home", "Home");
     89    keyMap().set("KP_End", "End");
     90    keyMap().set("KP_Insert", "Insert");
     91    keyMap().set("KP_Delete", "U+007F");
    8192}
    8293
    … …  
    132143    windowsKeyMap().set("apostrophe", VK_OEM_7);
    133144    windowsKeyMap().set("quotedbl", VK_OEM_7);
     145    // Keypad location
     146    windowsKeyMap().set("KP_Left", VK_LEFT);
     147    windowsKeyMap().set("KP_Right", VK_RIGHT);
     148    windowsKeyMap().set("KP_Up", VK_UP);
     149    windowsKeyMap().set("KP_Down", VK_DOWN);
     150    windowsKeyMap().set("KP_Prior", VK_PRIOR);
     151    windowsKeyMap().set("KP_Next", VK_NEXT);
     152    windowsKeyMap().set("KP_Home", VK_HOME);
     153    windowsKeyMap().set("KP_End", VK_END);
     154    windowsKeyMap().set("KP_Insert", VK_INSERT);
     155    windowsKeyMap().set("KP_Delete", VK_DELETE);
    134156
    135157    // Set alphabet to the windowsKeyMap.

  • trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp

    r110077 r116452  
    5050    , m_macCharCode(0)
    5151    , m_autoRepeat(false)
    52     , m_isKeypad(false)
     52    , m_isKeypad(String(event->key).startsWith("KP_"))
    5353    , m_isSystemKey(false)
    5454{
    … …  
    6464    , m_macCharCode(0)
    6565    , m_autoRepeat(false)
    66     , m_isKeypad(false)
     66    , m_isKeypad(String(event->key).startsWith("KP_"))
    6767    , m_isSystemKey(false)
    6868{
Note: See TracChangeset for help on using the changeset viewer.