Changeset 116562 in webkit
- Timestamp:
- May 9, 2012 3:09:10 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r116561 r116562 1 2012-05-09 Alec Flett <alecflett@chromium.org> 2 3 IndexedDB: call abort handler when there are problems committing 4 https://bugs.webkit.org/show_bug.cgi?id=85841 5 6 Reviewed by Ojan Vafai. 7 8 No new tests. Every existing test that calls commit() is testing 9 the success side of this, and this only throws when there are 10 LevelDB errors, which is exactly what we're trying to diagnose 11 with this patch. 12 13 * Modules/indexeddb/IDBBackingStore.h: 14 (Transaction): 15 * Modules/indexeddb/IDBLevelDBBackingStore.cpp: 16 (WebCore::IDBLevelDBBackingStore::deleteDatabase): 17 (WebCore::IDBLevelDBBackingStore::Transaction::commit): 18 * Modules/indexeddb/IDBLevelDBBackingStore.h: 19 (Transaction): 20 * Modules/indexeddb/IDBTransactionBackendImpl.cpp: 21 (WebCore::IDBTransactionBackendImpl::commit): 22 1 23 2012-05-09 Mark Pilgrim <pilgrim@chromium.org> 2 24 -
trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.h
r115997 r116562 114 114 virtual ~Transaction() { } 115 115 virtual void begin() = 0; 116 virtual voidcommit() = 0;116 virtual bool commit() = 0; 117 117 virtual void rollback() = 0; 118 118 }; -
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp
r116170 r116562 310 310 m_currentTransaction->remove(key); 311 311 312 transaction->commit(); 313 return true; 312 return transaction->commit(); 314 313 } 315 314 … … 1576 1575 } 1577 1576 1578 voidIDBLevelDBBackingStore::Transaction::commit()1577 bool IDBLevelDBBackingStore::Transaction::commit() 1579 1578 { 1580 1579 ASSERT(m_backingStore->m_currentTransaction); 1581 m_backingStore->m_currentTransaction->commit();1580 bool result = m_backingStore->m_currentTransaction->commit(); 1582 1581 m_backingStore->m_currentTransaction.clear(); 1582 return result; 1583 1583 } 1584 1584 -
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h
r115997 r116562 94 94 static PassRefPtr<Transaction> create(IDBLevelDBBackingStore*); 95 95 virtual void begin(); 96 virtual voidcommit();96 virtual bool commit(); 97 97 virtual void rollback(); 98 98 -
trunk/Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp
r109493 r116562 198 198 m_state = Finished; 199 199 closeOpenCursors(); 200 m_transaction->commit(); 201 m_callbacks->onComplete(); 200 if (m_transaction->commit()) 201 m_callbacks->onComplete(); 202 else 203 m_callbacks->onAbort(); 202 204 m_database->transactionCoordinator()->didFinishTransaction(this); 203 205 m_database->transactionFinished(this);
Note: See TracChangeset
for help on using the changeset viewer.