Changeset 116571 in webkit


Ignore:
Timestamp:
May 9, 2012 4:10:21 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Use suitable viewport values on XHTML-MP pages.
​https://bugs.webkit.org/show_bug.cgi?id=85425

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.

.:

Add LEGACY_VIEWPORT_ADAPTION use feature to cmake build system,
this feature will enable the use of a suitable viewport size
on legacy XHTML-MP pages.

  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Tests: fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html

fast/viewport/viewport-legacy-xhtmlmp-ordering.html
fast/viewport/viewport-legacy-xhtmlmp.html

Use device-width and device-height as viewport size on
XHTML-MP pages if the use feature LEGACY_VIEWPORT_ADAPTION
is set according as the non normative section of
​http://www.w3.org/TR/css-device-adapt/

  • dom/Document.cpp:

(WebCore::Document::setDocType):

Tools:

Enable LEGACY_VIEWPORT_ADAPTION on Qt port.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Add tests for legacy viewport adaption and skip them
on all ports but the Qt one.

  • fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt: Added.
  • fast/viewport/viewport-legacy-xhtmlmp-ordering.html: Added.
  • fast/viewport/viewport-legacy-xhtmlmp.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
Location:
trunk
Files:
6 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r116536 r116571  
     12012-05-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
     2
     3        Use suitable viewport values on XHTML-MP pages.
     4        https://bugs.webkit.org/show_bug.cgi?id=85425
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Add LEGACY_VIEWPORT_ADAPTION use feature to cmake build system,
     9        this feature will enable the use of a suitable viewport size
     10        on legacy XHTML-MP pages.
     11
     12        * Source/cmake/WebKitFeatures.cmake:
     13
    1142012-05-09  Crystal Zhang  <haizhang@rim.com>
    215

  • trunk/LayoutTests/ChangeLog

    r116563 r116571  
     12012-05-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
     2
     3        Use suitable viewport values on XHTML-MP pages.
     4        https://bugs.webkit.org/show_bug.cgi?id=85425
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Add tests for legacy viewport adaption and skip them
     9        on all ports but the Qt one.
     10
     11        * fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
     12        * fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt: Added.
     13        * fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html: Added.
     14        * fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt: Added.
     15        * fast/viewport/viewport-legacy-xhtmlmp-ordering.html: Added.
     16        * fast/viewport/viewport-legacy-xhtmlmp.html: Added.
     17        * platform/chromium/test_expectations.txt:
     18        * platform/efl/Skipped:
     19        * platform/gtk/test_expectations.txt:
     20
    1212012-05-09  Jochen Eisinger  <jochen@chromium.org>
    222

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r116510 r116571  
    11191119WONTFIX SKIP : media/audio-delete-while-step-button-clicked.html = TIMEOUT
    11201120
     1121// Feature disabled on chromium build, see: https://bugs.webkit.org/show_bug.cgi?id=85425
     1122WONTFIX SKIP : fast/viewport/viewport-legacy-xhtmlmp.html = FAIL
     1123
    11211124// We haven't implemented reverse audio/video playback.
    11221125BUGCR33099 SKIP : media/video-reverse-play-duration.html = TIMEOUT

  • trunk/LayoutTests/platform/efl/Skipped

    r116563 r116571  
    418418fast/viewport/viewport-warnings-4.html
    419419fast/viewport/viewport-warnings-6.html
     420
     421# Feature disabled on EFL build
     422# See https://bugs.webkit.org/show_bug.cgi?id=85425
     423fast/viewport/viewport-legacy-xhtmlmp.html
    420424
    421425# viewport meta tag tests that failed because window.devicePixelRatio is not implemented

  • trunk/LayoutTests/platform/gtk/test_expectations.txt

    r116553 r116571  
    3636// Expected failures
    3737//////////////////////////////////////////////////////////////////////////////////////////
     38
     39// Feature disabled, see: https://bugs.webkit.org/show_bug.cgi?id=85425
     40BUGWKGTK SKIP : fast/viewport/viewport-legacy-xhtmlmp.html = FAIL
    3841
    3942// Ignored because we do not have OBJC bindings (via Chromium).

  • trunk/Source/WebCore/ChangeLog

    r116570 r116571  
     12012-05-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
     2
     3        Use suitable viewport values on XHTML-MP pages.
     4        https://bugs.webkit.org/show_bug.cgi?id=85425
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Tests: fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html
     9               fast/viewport/viewport-legacy-xhtmlmp-ordering.html
     10               fast/viewport/viewport-legacy-xhtmlmp.html
     11
     12        Use device-width and device-height as viewport size on
     13        XHTML-MP pages if the use feature LEGACY_VIEWPORT_ADAPTION
     14        is set according as the non normative section of
     15        http://www.w3.org/TR/css-device-adapt/
     16
     17        * dom/Document.cpp:
     18        (WebCore::Document::setDocType):
     19
    1202012-05-09  Beth Dakin  <bdakin@apple.com>
    221

  • trunk/Source/WebCore/dom/Document.cpp

    r116471 r116571  
    772772    ASSERT(!m_docType || !docType);
    773773    m_docType = docType;
    774     if (m_docType)
     774    if (m_docType) {
    775775        this->adoptIfNeeded(m_docType.get());
     776#if USE(LEGACY_VIEWPORT_ADAPTION)
     777        ASSERT(m_viewportArgument.type == Implicit);
     778        if (m_docType->publicId().startsWith("-//wapforum//dtd xhtml mobile 1.", /* caseSensitive */ false))
     779            processViewport("width=device-width, height=device-height, initial-scale=1");
     780#endif
     781    }
    776782    // Doctype affects the interpretation of the stylesheets.
    777783    clearStyleResolver();

  • trunk/Source/cmake/WebKitFeatures.cmake

    r116436 r116571  
    9696    WEBKIT_OPTION_DEFINE(USE_SYSTEM_MALLOC "Toggle system allocator instead of TCmalloc" OFF)
    9797    WEBKIT_OPTION_DEFINE(USE_TILED_BACKING_STORE "Toggle Tiled Backing Store support" OFF)
     98    WEBKIT_OPTION_DEFINE(USE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF)
    9899    WEBKIT_OPTION_DEFINE(USE_WTFURL "Toogle the use of WTFURL for URL parsing" OFF)
    99100ENDMACRO ()

  • trunk/Tools/ChangeLog

    r116563 r116571  
     12012-05-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
     2
     3        Use suitable viewport values on XHTML-MP pages.
     4        https://bugs.webkit.org/show_bug.cgi?id=85425
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
     9
     10        * qmake/mkspecs/features/features.prf:
     11
    1122012-05-09  Jochen Eisinger  <jochen@chromium.org>
    213

  • trunk/Tools/qmake/mkspecs/features/features.prf

    r116403 r116571  
    7878# Tiled Backing Store support
    7979!contains(DEFINES, WTF_USE_TILED_BACKING_STORE=.): DEFINES += WTF_USE_TILED_BACKING_STORE=1
     80
     81# Turn on legacy viewport adaption
     82!contains(DEFINES, WTF_USE_LEGACY_VIEWPORT_ADAPTION=.): DEFINES += WTF_USE_LEGACY_VIEWPORT_ADAPTION=1
    8083
    8184# Nescape plugins support (NPAPI)
Note: See TracChangeset for help on using the changeset viewer.