Changeset 116580 in webkit

Timestamp:

May 9, 2012 5:14:49 PM (12 years ago)

Author:

arv@chromium.org

Message:

[V8] Fix issue where V8BindingPerContextData could keep the context object alive
​https://bugs.webkit.org/show_bug.cgi?id=86036

Reviewed by Kentaro Hara.

This is a partial revert of ​http://trac.webkit.org/changeset/114320/. This keeps
the layout tests that were introduced since it turns out that
​http://trac.webkit.org/changeset/114989 fixes the tests too.

Covered by: http/tests/security/isolatedWorld/context-destroy.html

• bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::destroy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8IsolatedContext.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-09  Erik Arvidsson  <arv@chromium.org>
+
+        [V8] Fix issue where V8BindingPerContextData could keep the context object alive
+        https://bugs.webkit.org/show_bug.cgi?id=86036
+
+        Reviewed by Kentaro Hara.
+
+        This is a partial revert of http://trac.webkit.org/changeset/114320/. This keeps
+        the layout tests that were introduced since it turns out that
+        http://trac.webkit.org/changeset/114989 fixes the tests too.
+
+        Covered by: http/tests/security/isolatedWorld/context-destroy.html
+
+        * bindings/v8/V8IsolatedContext.cpp:
+        (WebCore::V8IsolatedContext::destroy):
+
 2012-05-09  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp

@@ -106 +106 @@
 void V8IsolatedContext::destroy()
 {
+    m_perContextData.clear();
     m_frame->loader()->client()->willReleaseScriptContext(context(), m_world->id());
     m_context->get().MakeWeak(this, &contextWeakReferenceCallback);