Changeset 116618 in webkit

Timestamp:

May 10, 2012 12:42:03 AM (12 years ago)

Author:

inferno@chromium.org

Message:

Make DOMCharacterDataModified a scoped event (similar to r73690).
​https://bugs.webkit.org/show_bug.cgi?id=85920

Reviewed by Ryosuke Niwa.

Source/WebCore:

DOMCharacterDataModified was missing in the list of already scoped
DOM mutation events like DOMSubtreeModified, DOMNodeInserted, etc.
It helps to delay event dispatches until the completion of each call
of EditCommand::doApply. This has been useful in the past and helped to
prevent unexpected DOM tree mutations while the editing command is executing.

• dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

• fast/events/scoped/editing-commands.html: test modified to check DOMCharacterDataModified event.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/scoped/editing-commands.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/CharacterData.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-10  Abhishek Arya  <inferno@chromium.org>
+
+        Make DOMCharacterDataModified a scoped event (similar to r73690).
+        https://bugs.webkit.org/show_bug.cgi?id=85920
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/events/scoped/editing-commands.html: test modified to check DOMCharacterDataModified event.
+
 2012-05-10  Zan Dobersek  <zandobersek@gmail.com>
 

trunk/LayoutTests/fast/events/scoped/editing-commands.html

@@ -48 +48 @@
 
 var events = {
+    'DOMCharacterDataModified': false,
     'DOMSubtreeModified': false,
     'DOMNodeInserted': false,

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-10  Abhishek Arya  <inferno@chromium.org>
+
+        Make DOMCharacterDataModified a scoped event (similar to r73690).
+        https://bugs.webkit.org/show_bug.cgi?id=85920
+
+        Reviewed by Ryosuke Niwa.
+
+        DOMCharacterDataModified was missing in the list of already scoped
+        DOM mutation events like DOMSubtreeModified, DOMNodeInserted, etc.
+        It helps to delay event dispatches until the completion of each call
+        of EditCommand::doApply. This has been useful in the past and helped to 
+        prevent unexpected DOM tree mutations while the editing command is executing.
+
+        * dom/CharacterData.cpp:
+        (WebCore::CharacterData::dispatchModifiedEvent):
+
 2012-05-10  Alexandre Elias  <aelias@google.com>
 

trunk/Source/WebCore/dom/CharacterData.cpp

@@ -201 +201 @@
         parentNode()->childrenChanged();
     if (document()->hasListenerType(Document::DOMCHARACTERDATAMODIFIED_LISTENER))
-        dispatchEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, 0, oldData, m_data));
+        dispatchScopedEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, 0, oldData, m_data));
     dispatchSubtreeModifiedEvent();
 #if ENABLE(INSPECTOR)