Changeset 116638 in webkit

Timestamp:

May 10, 2012 6:42:54 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Memory leaks found in EFL DRT
​https://bugs.webkit.org/show_bug.cgi?id=85889

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
created with JSStringCreateWithUTF8CString.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

• DumpRenderTree/efl/EventSender.cpp:

(modifiersFromJSValue):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (1 diff)
• DumpRenderTree/efl/EventSender.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] Memory leaks found in EFL DRT
+        https://bugs.webkit.org/show_bug.cgi?id=85889
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
+        created with JSStringCreateWithUTF8CString.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::onWindowObjectCleared):
+        * DumpRenderTree/efl/EventSender.cpp:
+        (modifiersFromJSValue):
+
 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -368 +368 @@
     ASSERT(!exception);
 
-    JSRetainPtr<JSStringRef> controllerName(JSStringCreateWithUTF8CString("eventSender"));
+    JSRetainPtr<JSStringRef> controllerName(Adopt, JSStringCreateWithUTF8CString("eventSender"));
     JSObjectSetProperty(objectClearedInfo->context, objectClearedInfo->windowObject,
                         controllerName.get(),

trunk/Tools/DumpRenderTree/efl/EventSender.cpp

@@ -237 +237 @@
 
     unsigned modifier = 0;
-    int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, JSStringCreateWithUTF8CString("length"), 0), 0);
+    JSRetainPtr<JSStringRef> lengthProperty(Adopt, JSStringCreateWithUTF8CString("length"));
+    int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, lengthProperty.get(), 0), 0);
     for (int i = 0; i < modifiersCount; ++i)
         modifier |= static_cast<unsigned>(modifierFromJSValue(context, JSObjectGetPropertyAtIndex(context, modifiersArray, i, 0)));