Changeset 116662 in webkit

Timestamp:

May 10, 2012 11:15:04 AM (12 years ago)

Author:

rakuco@webkit.org

Message:

[EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
​https://bugs.webkit.org/show_bug.cgi?id=86117

Reviewed by Adam Barth.

Simplify the code used to wrap driver calls with jhbuild: we can
just define the 'wrapper' option instead of having to create a
Driver class just for that.

• Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init):
(EflPort._port_flag_for_scripts):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/efl.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
+
+        [EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
+        https://bugs.webkit.org/show_bug.cgi?id=86117
+
+        Reviewed by Adam Barth.
+
+        Simplify the code used to wrap driver calls with jhbuild: we can
+        just define the 'wrapper' option instead of having to create a
+        Driver class just for that.
+
+        * Scripts/webkitpy/layout_tests/port/efl.py:
+        (EflPort.__init__):
+        (EflPort._port_flag_for_scripts):
+
 2012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py

@@ -33 +33 @@
 
 from webkitpy.layout_tests.models.test_configuration import TestConfiguration
-from webkitpy.layout_tests.port.webkit import WebKitDriver, WebKitPort
+from webkitpy.layout_tests.port.webkit import WebKitPort
 from webkitpy.layout_tests.port.pulseaudio_sanitizer import PulseAudioSanitizer
-
-
-class EflDriver(WebKitDriver):
-    def cmd_line(self, pixel_tests, per_test_args):
-        wrapper_path = self._port.path_from_webkit_base("Tools", "efl", "run-with-jhbuild")
-        return [wrapper_path] + WebKitDriver.cmd_line(self, pixel_tests, per_test_args)
 
 
@@ -46 +40 @@
     port_name = 'efl'
 
+    def __init__(self, *args, **kwargs):
+        WebKitPort.__init__(self, *args, **kwargs)
+
+        self.set_option_default('wrapper', self.path_from_webkit_base('Tools', 'efl', 'run-with-jhbuild'))
+
     def _port_flag_for_scripts(self):
         return "--efl"
-
-    def _driver_class(self):
-        return EflDriver
 
     def setup_test_run(self):