Changeset 116681 in webkit

Timestamp:

May 10, 2012 1:24:20 PM (12 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: heap snapshot comparison view is broken
​https://bugs.webkit.org/show_bug.cgi?id=86102

Reviewed by Pavel Feldman.

Pass HeapSnapshotProxy instead of undefined to the profile load callback. Added
compiler annotations to avoid such errors in the future.

• inspector/front-end/HeapSnapshotView.js:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/HeapSnapshotView.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-10  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: heap snapshot comparison view is broken
+        https://bugs.webkit.org/show_bug.cgi?id=86102
+
+        Reviewed by Pavel Feldman.
+
+        Pass HeapSnapshotProxy instead of undefined to the profile load callback. Added
+        compiler annotations to avoid such errors in the future.
+
+        * inspector/front-end/HeapSnapshotView.js:
+
 2012-05-10  Zan Dobersek  <zandobersek@gmail.com>
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js

@@ -791 +791 @@
     /**
      * @override
-     * @param {Function} callback
+     * @param {function(WebInspector.HeapSnapshotProxy):void} callback
      */
     load: function(callback)
     {
         if (this._loaded) {
-            callback.call(null);
+            callback(this._proxy);
             return;
         }