Changeset 117374 in webkit

Timestamp:

May 16, 2012 6:19:31 PM (12 years ago)

Author:

haraken@chromium.org

Message:

[V8] Pass Isolate to convertEventTargetToV8Object()
​https://bugs.webkit.org/show_bug.cgi?id=86566

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to convertEventTargetToV8Object().
I made the 'isolate' argument optional, since
convertEventTargetToV8Object() can be called from the WebCore context.

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

• bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

• bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)
• bindings/v8/V8DOMWrapper.cpp (modified) (1 diff)
• bindings/v8/V8DOMWrapper.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-16  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Pass Isolate to convertEventTargetToV8Object()
+        https://bugs.webkit.org/show_bug.cgi?id=86566
+
+        Reviewed by Nate Chapin.
+
+        The objective is to pass Isolate around in V8 bindings.
+        This patch passes Isolate to convertEventTargetToV8Object().
+        I made the 'isolate' argument optional, since
+        convertEventTargetToV8Object() can be called from the WebCore context.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (NativeToJSValue):
+        * bindings/v8/V8DOMWrapper.cpp:
+        (WebCore):
+        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
+        * bindings/v8/V8DOMWrapper.h:
+        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
+        (V8DOMWrapper):
+
 2012-05-16  Peter Kasting  <pkasting@google.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -3828 +3828 @@
 
     if ($type eq "EventTarget") {
-        return "V8DOMWrapper::convertEventTargetToV8Object($value)";
+        return "V8DOMWrapper::convertEventTargetToV8Object($value, $getIsolate)";
     }
 

trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp

@@ -254 +254 @@
 #define TRY_TO_WRAP_WITH_INTERFACE(interfaceName) \
     if (eventNames().interfaceFor##interfaceName == desiredInterface) \
-        return toV8(static_cast<interfaceName*>(target));
+        return toV8(static_cast<interfaceName*>(target), isolate);
 
 // A JS object of type EventTarget is limited to a small number of possible classes.
-v8::Handle<v8::Value> V8DOMWrapper::convertEventTargetToV8Object(EventTarget* target)
+v8::Handle<v8::Value> V8DOMWrapper::convertEventTargetToV8Object(EventTarget* target, v8::Isolate* isolate)
 {
     if (!target)

trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h

@@ -87 +87 @@
         static WrapperTypeInfo* domWrapperType(v8::Handle<v8::Object>);
 
-        static v8::Handle<v8::Value> convertEventTargetToV8Object(PassRefPtr<EventTarget> eventTarget)
+        static v8::Handle<v8::Value> convertEventTargetToV8Object(PassRefPtr<EventTarget> eventTarget, v8::Isolate* isolate = 0)
         {
-            return convertEventTargetToV8Object(eventTarget.get());
+            return convertEventTargetToV8Object(eventTarget.get(), isolate);
         }
 
-        static v8::Handle<v8::Value> convertEventTargetToV8Object(EventTarget*);
+        static v8::Handle<v8::Value> convertEventTargetToV8Object(EventTarget*, v8::Isolate* = 0);
 
         static PassRefPtr<EventListener> getEventListener(v8::Local<v8::Value> value, bool isAttribute, ListenerLookupType lookup);