Changeset 117435 in webkit

Timestamp:

May 17, 2012 5:30:11 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt][WK2] fast/events/page-visibility-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=83263

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Handle "preview" state and avoid string conversion.

• WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):

LayoutTests:

Unskip two page-visibility tests: iframe-propagation-test.html
and transition-test.html.

• platform/qt-5.0-wk2/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt-5.0-wk2/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-17  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        [Qt][WK2] fast/events/page-visibility-* tests fail
+        https://bugs.webkit.org/show_bug.cgi?id=83263
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Unskip two page-visibility tests: iframe-propagation-test.html
+        and transition-test.html.
+
+        * platform/qt-5.0-wk2/Skipped:
+
 2012-05-17  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

@@ -77 +77 @@
 # https://bugs.webkit.org/show_bug.cgi?id=83263
 fast/events/page-visibility-iframe-move-test.html
-fast/events/page-visibility-iframe-propagation-test.html
-fast/events/page-visibility-transition-test.html
 
 svg/custom/mouse-move-on-svg-container.xhtml

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-17  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        [Qt][WK2] fast/events/page-visibility-* tests fail
+        https://bugs.webkit.org/show_bug.cgi?id=83263
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Handle "preview" state and avoid string conversion.
+
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+        (WTR::LayoutTestController::setPageVisibility):
+
 2012-05-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp

@@ -546 +546 @@
 void LayoutTestController::setPageVisibility(JSStringRef state)
 {
-    WKStringRef visibilityStateKey = toWK(state).get();
     WebCore::PageVisibilityState visibilityState = WebCore::PageVisibilityStateVisible;
 
-    if (WKStringIsEqualToUTF8CString(visibilityStateKey, "hidden"))
+    if (JSStringIsEqualToUTF8CString(state, "hidden"))
         visibilityState = WebCore::PageVisibilityStateHidden;
-    else if (WKStringIsEqualToUTF8CString(visibilityStateKey, "prerender"))
+    else if (JSStringIsEqualToUTF8CString(state, "prerender"))
         visibilityState = WebCore::PageVisibilityStatePrerender;
+    else if (JSStringIsEqualToUTF8CString(state, "preview"))
+        visibilityState = WebCore::PageVisibilityStatePreview;
 
     WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), visibilityState, /* isInitialState */ false);