Changeset 117442 in webkit

Timestamp:

May 17, 2012 6:32:09 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=86716

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

Added a new context menu to provide Remove All DOM breakpoint option.

UI Feature. Tests not required.

• English.lproj/localizedStrings.js:
• inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/DOMBreakpointsSidebarPane.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Vivek Galatage  <vivekgalatage@gmail.com>
+
+        Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
+        https://bugs.webkit.org/show_bug.cgi?id=86716
+
+        Reviewed by Yury Semikhatsky.
+
+        Added a new context menu to provide Remove All DOM breakpoint option.
+
+        UI Feature. Tests not required.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/DOMBreakpointsSidebarPane.js:
+        (WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
+        (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
+
 2012-05-17  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js

@@ -212 +212 @@
     },
 
+    _removeAllBreakpoints: function()
+    {
+        for (var id in this._breakpointElements) {
+            var element = this._breakpointElements[id];
+            this._removeBreakpoint(element._node, element._type);
+        }
+        this._saveBreakpoints();
+    },
+
     _removeBreakpoint: function(node, type)
     {
@@ -234 +243 @@
         }
         contextMenu.appendItem(WebInspector.UIString("Remove Breakpoint"), removeBreakpoint.bind(this));
+        contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Remove all DOM breakpoints" : "Remove All DOM Breakpoints"), this._removeAllBreakpoints.bind(this));
         contextMenu.show(event);
     },