Changeset 117476 in webkit

Timestamp:

May 17, 2012 12:04:53 PM (12 years ago)

Author:

eae@chromium.org

Message:

Fix rounding in RenderFlowThread::paintIntoRegion
​https://bugs.webkit.org/show_bug.cgi?id=86695

Reviewed by Eric Seidel.

Fix rounding of offset in paintIntoRegion to ensure that we paint on
device pixel boundaries.

Covered by existing tests in fast/regions.

• platform/graphics/FractionalLayoutPoint.h:

(WebCore::roundedIntPoint):
Add roundedIntPoint(FractionalLayoutSize) function.
(WebCore):

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FractionalLayoutPoint.h (modified) (1 diff)
• rendering/RenderFlowThread.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Emil A Eklund  <eae@chromium.org>
+
+        Fix rounding in RenderFlowThread::paintIntoRegion
+        https://bugs.webkit.org/show_bug.cgi?id=86695
+
+        Reviewed by Eric Seidel.
+
+        Fix rounding of offset in paintIntoRegion to ensure that we paint on
+        device pixel boundaries.
+
+        Covered by existing tests in fast/regions.
+
+        * platform/graphics/FractionalLayoutPoint.h:
+        (WebCore::roundedIntPoint):
+        Add roundedIntPoint(FractionalLayoutSize) function.
+        (WebCore):
+        * rendering/RenderFlowThread.cpp:
+        (WebCore::RenderFlowThread::paintIntoRegion):
+
 2012-05-17  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/platform/graphics/FractionalLayoutPoint.h

@@ -168 +168 @@
 }
 
+inline IntPoint roundedIntPoint(const FractionalLayoutSize& size)
+{
+    return IntPoint(size.width().round(), size.height().round());
+}
+
 inline IntPoint ceiledIntPoint(const FractionalLayoutPoint& point)
 {

trunk/Source/WebCore/rendering/RenderFlowThread.cpp

@@ -293 +293 @@
         // from the region rect's current position. The amount of offset is equal to the location of
         // region in flow coordinates.
-        LayoutPoint renderFlowThreadOffset;
+        IntPoint renderFlowThreadOffset;
         if (style()->isFlippedBlocksWritingMode()) {
             LayoutRect flippedRegionRect(regionRect);
             flipForWritingMode(flippedRegionRect);
-            renderFlowThreadOffset = LayoutPoint(paintOffset - flippedRegionRect.location());
+            renderFlowThreadOffset = roundedIntPoint(paintOffset - flippedRegionRect.location());
         } else
-            renderFlowThreadOffset = LayoutPoint(paintOffset - regionRect.location());
+            renderFlowThreadOffset = roundedIntPoint(paintOffset - regionRect.location());
 
         context->translate(renderFlowThreadOffset.x(), renderFlowThreadOffset.y());
-        info.rect.moveBy(-roundedIntPoint(renderFlowThreadOffset));
+        info.rect.moveBy(-renderFlowThreadOffset);
         
         layer()->paint(context, info.rect, 0, 0, region, RenderLayer::PaintLayerTemporaryClipRects);