Changeset 117965 in webkit

Timestamp:

May 22, 2012 6:50:35 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: JavaScript breakpoints disappear when Ctrl+S is pressed for the script without changes.
​https://bugs.webkit.org/show_bug.cgi?id=87121

Reviewed by Pavel Feldman.

JavaScriptSourceFrame and StylesSourceFrame should not commit working copy unless UISourceCode is dirty.

• inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):

• inspector/front-end/StylesPanel.js:

(WebInspector.StyleSourceFrame.prototype.commitEditing):

• inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.commitWorkingCopy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/JavaScriptSourceFrame.js (modified) (1 diff)
• inspector/front-end/StylesPanel.js (modified) (1 diff)
• inspector/front-end/UISourceCode.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-22  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: JavaScript breakpoints disappear when Ctrl+S is pressed for the script without changes.
+        https://bugs.webkit.org/show_bug.cgi?id=87121
+
+        Reviewed by Pavel Feldman.
+
+        JavaScriptSourceFrame and StylesSourceFrame should not commit working copy unless UISourceCode is dirty.
+
+        * inspector/front-end/JavaScriptSourceFrame.js:
+        (WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
+        * inspector/front-end/StylesPanel.js:
+        (WebInspector.StyleSourceFrame.prototype.commitEditing):
+        * inspector/front-end/UISourceCode.js:
+        (WebInspector.UISourceCode.prototype.commitWorkingCopy):
+
 2012-05-22  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js

@@ -93 +93 @@
     commitEditing: function(text)
     {
+        if (!this._uiSourceCode.isDirty())
+            return;
+
         this._isCommittingEditing = true;
         this._uiSourceCode.commitWorkingCopy(this._didEditContent.bind(this));

trunk/Source/WebCore/inspector/front-end/StylesPanel.js

@@ -146 +146 @@
     commitEditing: function(text)
     {
+        if (!this._styleSource.isDirty())
+            return;
+
         this._isCommittingEditing = true;
         this._styleSource.commitWorkingCopy(this._didEditContent.bind(this));

trunk/Source/WebCore/inspector/front-end/UISourceCode.js

@@ -212 +212 @@
         }
 
-        if (!this.isDirty()) {
-            callback(null);
-            return;
-        }
-
         var newContent = this._workingCopy;
         this._committingWorkingCopy = true;