Changeset 117987 in webkit

Timestamp:

May 22, 2012 9:41:12 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Make color of spelling check marker cross-platform.
​https://bugs.webkit.org/show_bug.cgi?id=87095

Patch by Hao Zheng <​zhenghao@chromium.org> on 2012-05-22
Reviewed by Adam Barth.

Pixel layout is RGBA on Android, while it is BGRA on other platforms.

No new tests. To run tests on Android.

• platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/GraphicsContextSkia.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-22  Hao Zheng  <zhenghao@chromium.org>
+
+        [chromium] Make color of spelling check marker cross-platform.
+        https://bugs.webkit.org/show_bug.cgi?id=87095
+
+        Reviewed by Adam Barth.
+
+        Pixel layout is RGBA on Android, while it is BGRA on other platforms.
+
+        No new tests. To run tests on Android.
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+        (WebCore::GraphicsContext::drawLineForDocumentMarker):
+
 2012-05-22  Dana Jansens  <danakj@chromium.org>
 

trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

@@ -550 +550 @@
         }
 #else
-        const uint32_t lineColor = 0xFFFF0000;  // Opaque red.
-        const uint32_t antiColor = 0x60600000;  // Semitransparent red.
+        const uint32_t lineColor = 0xFF << SK_A32_SHIFT | 0xFF << SK_R32_SHIFT; // Opaque red.
+        const uint32_t antiColor = 0x60 << SK_A32_SHIFT | 0x60 << SK_R32_SHIFT; // Semitransparent red
 
         // Pattern:  X o   o X o   o X
@@ -1119 +1119 @@
 
 }  // namespace WebCore
-