Changeset 118404 in webkit

Timestamp:

May 24, 2012 12:38:10 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] [DRT] keyboard-related tests do not pass
​https://bugs.webkit.org/show_bug.cgi?id=85369

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-24
Reviewed by Gustavo Noronha Silva.

Tools:

Add SHIFT modifier for capital letters as VK_
codes do not distinguish between lows and caps and also to be consistent
with other ports which send caps as lowercase letters with the shift key down.

• DumpRenderTree/efl/EventSender.cpp:

(keyNameFromJSValue):

LayoutTests:

• platform/efl/Skipped: Unskipped keyboard-related tests.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/EventSender.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] [DRT] keyboard-related tests do not pass
+        https://bugs.webkit.org/show_bug.cgi?id=85369
+
+        Reviewed by Gustavo Noronha Silva.
+
+        * platform/efl/Skipped: Unskipped keyboard-related tests.
+
 2012-05-24  Joshua Bell  <jsbell@chromium.org>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -602 +602 @@
 fast/events/drag-in-frames.html
 fast/events/drag-parent-node.html
-
-# BUG: keyboard-related bugs, generally in the EventSender-PlatformKeyboardEventEfl interaction
-fast/events/key-events-in-input-button.html
-fast/events/key-events-in-input-text.html
-fast/events/option-tab.html
 
 # BUG: not scrolling correctly

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] [DRT] keyboard-related tests do not pass
+        https://bugs.webkit.org/show_bug.cgi?id=85369
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Add SHIFT modifier for capital letters as VK_ 
+        codes do not distinguish between lows and caps and also to be consistent
+        with other ports which send caps as lowercase letters with the shift key down.
+
+        * DumpRenderTree/efl/EventSender.cpp:
+        (keyNameFromJSValue): 
+
 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/DumpRenderTree/efl/EventSender.cpp

@@ -488 +488 @@
         return new KeyEventInfo("Escape", "Escape", modifiers);
 
+    if ((character->length() == 1) && (charCode >= 'A' && charCode <= 'Z'))
+        modifiers |= EvasKeyModifierShift;
+
     return new KeyEventInfo(character->ustring().utf8(), character->ustring().utf8(), modifiers);
 }