Changeset 118491 in webkit

Timestamp:

May 25, 2012 1:00:35 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] API for PageGroup visited links hash populating
​https://bugs.webkit.org/show_bug.cgi?id=86370

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-25
Reviewed by Kenneth Rohde Christiansen.

Added "populate,visited,links" ewk_view signal that tells to the client managing
persistent history storage to fill the visited links cache.
Added API for the PageGroup visited links hash populating.

• WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::populateVisitedLinks): Implementation added (sends notification).
(WebCore):

• WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

• ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_visited_link_add): PageGroup visited links hash populating.

• ewk/ewk_view.h:

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientEfl.cpp (modified) (1 diff)
• WebCoreSupport/ChromeClientEfl.h (modified) (1 diff)
• ewk/ewk_view.cpp (modified) (2 diffs)
• ewk/ewk_view.h (modified) (2 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-05-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] API for PageGroup visited links hash populating
+        https://bugs.webkit.org/show_bug.cgi?id=86370
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Added "populate,visited,links" ewk_view signal that tells to the client managing
+        persistent history storage to fill the visited links cache.
+        Added API for the PageGroup visited links hash populating.
+
+        * WebCoreSupport/ChromeClientEfl.cpp:
+        (WebCore::ChromeClientEfl::populateVisitedLinks): Implementation added (sends notification).
+        (WebCore):
+        * WebCoreSupport/ChromeClientEfl.h:
+        (ChromeClientEfl):
+        * ewk/ewk_view.cpp:
+        (_Ewk_View_Private_Data):
+        (ewk_view_visited_link_add): PageGroup visited links hash populating.
+        * ewk/ewk_view.h:
+
 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 

trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp

@@ -410 +410 @@
 }
 
+void ChromeClientEfl::populateVisitedLinks()
+{
+    evas_object_smart_callback_call(m_view, "populate,visited,links", 0);
+}
+
 #if ENABLE(TOUCH_EVENTS)
 void ChromeClientEfl::needTouchEvents(bool needed)

trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h

@@ -126 +126 @@
     virtual void reachedApplicationCacheOriginQuota(SecurityOrigin*, int64_t totalSpaceNeeded);
 
+    virtual void populateVisitedLinks();
+
 #if ENABLE(TOUCH_EVENTS)
     virtual void needTouchEvents(bool);

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -48 +48 @@
 #include "LayoutTypes.h"
 #include "PageClientEfl.h"
+#include "PageGroup.h"
 #include "PlatformMouseEvent.h"
 #include "PopupMenuClient.h"
@@ -1706 +1707 @@
 }
 
+Eina_Bool ewk_view_visited_link_add(Evas_Object* ewkView, const char* visitedUrl)
+{
+    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
+    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
+
+    EINA_SAFETY_ON_NULL_RETURN_VAL(priv->page, false);
+    EINA_SAFETY_ON_NULL_RETURN_VAL(priv->page->groupPtr(), false);
+
+    WebCore::KURL kurl(WebCore::KURL(), WTF::String::fromUTF8(visitedUrl));
+    priv->page->groupPtr()->addVisitedLink(kurl);
+    return true;
+}
+
 float ewk_view_zoom_get(const Evas_Object* ewkView)
 {

trunk/Source/WebKit/efl/ewk/ewk_view.h

@@ -74 +74 @@
  *  - "protocolhandler,registration,requested", Ewk_Custom_Handler_Data: add a handler url for the given protocol.
  *  - "onload,event", Evas_Object*: a frame onload event has been received.
+ *  - "populate,visited,links": tells the client to fill the visited links set.
  *  - "ready", void: page is fully loaded.
  *  - "resource,request,new", Ewk_Frame_Resource_Request*: reports that
@@ -1102 +1103 @@
 
 /**
+ * Adds @a visited_url to the view's visited links cache.
+ *
+ * This function is to be invoked by the client managing persistent history storage
+ * when "populate,visited,links" signal is received.
+ *
+ * @param o view object to add visited links data.
+ * @param visited_url visited url.
+ *
+ * @return @c EINA_TRUE on success, @c EINA_FALSE on failure.
+ */
+EAPI Eina_Bool  ewk_view_visited_link_add(Evas_Object *o, const char *visited_url);
+
+/**
  * Gets the current page zoom level of the main frame.
  *