Changeset 119196 in webkit

Timestamp:

May 31, 2012 11:37:02 PM (12 years ago)

Author:

dominicc@chromium.org

Message:

[V8] Expando properties on attribute nodes disappear
​https://bugs.webkit.org/show_bug.cgi?id=87925

Source/WebCore:

Reviewed by Adam Barth.

Test: fast/dom/gc-attribute-node.html

• bindings/v8/V8GCController.cpp:

(WebCore::calculateGroupId): Group attributes like other nodes.

LayoutTests:

Checks in a failing result for JSC; see
<​https://bugs.webkit.org/show_bug.cgi?id=88045>.

Reviewed by Adam Barth.

• fast/dom/gc-attribute-node-expected.txt: Added.
• fast/dom/gc-attribute-node.html: Added.
• platform/chromium/fast/dom/gc-attribute-node-expected.txt: Added.
• platform/mac/fast/dom/gc-attribute-node-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/gc-attribute-node-expected.txt (added)
• LayoutTests/fast/dom/gc-attribute-node.html (added)
• LayoutTests/platform/chromium/fast/dom/gc-attribute-node-expected.txt (added)
• LayoutTests/platform/mac/fast/dom/gc-attribute-node-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/V8GCController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-31  Dominic Cooney  <dominicc@chromium.org>
+
+        [V8] Expando properties on attribute nodes disappear
+        https://bugs.webkit.org/show_bug.cgi?id=87925
+
+        Checks in a failing result for JSC; see
+        <https://bugs.webkit.org/show_bug.cgi?id=88045>.
+
+        Reviewed by Adam Barth.
+
+        * fast/dom/gc-attribute-node-expected.txt: Added.
+        * fast/dom/gc-attribute-node.html: Added.
+        * platform/chromium/fast/dom/gc-attribute-node-expected.txt: Added.
+        * platform/mac/fast/dom/gc-attribute-node-expected.txt: Added.
+
 2012-05-31  Alexander Shalamov  <alexander.shalamov@intel.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-31  Dominic Cooney  <dominicc@chromium.org>
+
+        [V8] Expando properties on attribute nodes disappear
+        https://bugs.webkit.org/show_bug.cgi?id=87925
+
+        Reviewed by Adam Barth.
+
+        Test: fast/dom/gc-attribute-node.html
+
+        * bindings/v8/V8GCController.cpp:
+        (WebCore::calculateGroupId): Group attributes like other nodes.
+
 2012-05-31  Alexander Shalamov  <alexander.shalamov@intel.com>
 

trunk/Source/WebCore/bindings/v8/V8GCController.cpp

@@ -307 +307 @@
         if (!root)
             return GroupId();
-    } else {
-        while (Node* parent = root->parentOrHostNode())
-            root = parent;
-    }
+    }
+    while (Node* parent = root->parentOrHostNode())
+        root = parent;
 
     return GroupId(root);