Changeset 119322 in webkit

Timestamp:

Jun 2, 2012 7:53:19 AM (12 years ago)

Author:

tonikitoo@webkit.org

Message:

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART III)
​https://bugs.webkit.org/show_bug.cgi?id=88019

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

Enter 'pure-with-mouse-conversion' mode when going fullscreen, so
that it prevents user from scrolling the WebPage, pinch zooming,
touch-and-hold, enter selection mode, etc ...

Internally reviewed by Gen Mak.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

• Api/WebPage_p.h:

(WebPagePrivate):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPage.cpp (modified) (3 diffs)
• Api/WebPage_p.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -358 +358 @@
     , m_cursorEventMode(ProcessedCursorEvents)
     , m_touchEventMode(ProcessedTouchEvents)
+#if ENABLE(FULLSCREEN_API)
+    , m_touchEventModePriorGoingFullScreen(ProcessedTouchEvents)
+#endif
 #endif
 #if ENABLE(FULLSCREEN_API)
@@ -6096 +6099 @@
         m_mainFrame->view()->setScrollPosition(WebCore::IntPoint(0, scrollPosition.y()));
 
+#if ENABLE(EVENT_MODE_METATAGS)
+        m_touchEventModePriorGoingFullScreen = m_touchEventMode;
+        didReceiveTouchEventMode(PureTouchEventsWithMouseConversion);
+#endif
         // No fullscreen video widget has been made available by the Browser
         // chrome, or this is not a video element. The webkitRequestFullScreen
@@ -6123 +6130 @@
         m_xScrollOffsetPriorGoingFullScreen = -1;
 
+#if ENABLE(EVENT_MODE_METATAGS)
+        didReceiveTouchEventMode(m_touchEventModePriorGoingFullScreen);
+        m_touchEventModePriorGoingFullScreen = ProcessedTouchEvents;
+#endif
         // This is where we would restore the browser's chrome
         // if hidden above.

trunk/Source/WebKit/blackberry/Api/WebPage_p.h

@@ -492 +492 @@
 
 #if ENABLE(FULLSCREEN_API)
+#if ENABLE(EVENT_MODE_METATAGS)
+    WebCore::TouchEventMode m_touchEventModePriorGoingFullScreen;
+#endif
     int m_xScrollOffsetPriorGoingFullScreen;
 #endif

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-06-02  Antonio Gomes  <agomes@rim.com>
+
+        [BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART III)
+        https://bugs.webkit.org/show_bug.cgi?id=88019
+
+        Reviewed by George Staikos.
+
+        Enter 'pure-with-mouse-conversion' mode when going fullscreen, so
+        that it prevents user from scrolling the WebPage, pinch zooming,
+        touch-and-hold, enter selection mode, etc ...
+
+        Internally reviewed by Gen Mak.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
+        (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
+        (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
+        * Api/WebPage_p.h:
+        (WebPagePrivate):
+
 2012-06-02  Antonio Gomes  <agomes@rim.com>