Changeset 120329 in webkit

Timestamp:

Jun 14, 2012 8:52:28 AM (12 years ago)

Author:

kling@webkit.org

Message:

Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari.
<​http://webkit.org/b/89048>
<rdar://problem/11449702>

Reviewed by Darin Adler.

Send the DidReceiveEvent message with the DispatchMessageEvenWhenWaitingForSyncReply flag
for keyboard events. This ensures that it always arrives before the corresponding synchronous
InterpretQueuedKeyEvent message.

The problem was that we relied on DidReceiveEvent / InterpretQueuedKeyEvent always arriving in
the same order they were sent. This was not always true, since DidReceiveEvent (async) would
get deferred during an unrelated waitForSyncReply() whereas InterpretQueuedKeyEvent (sync)
gets dispatched right away.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-06-13  Andreas Kling  <kling@webkit.org>
+
+        Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari.
+        <http://webkit.org/b/89048>
+        <rdar://problem/11449702>
+
+        Reviewed by Darin Adler.
+
+        Send the DidReceiveEvent message with the DispatchMessageEvenWhenWaitingForSyncReply flag
+        for keyboard events. This ensures that it always arrives before the corresponding synchronous
+        InterpretQueuedKeyEvent message.
+
+        The problem was that we relied on DidReceiveEvent / InterpretQueuedKeyEvent always arriving in
+        the same order they were sent. This was not always true, since DidReceiveEvent (async) would
+        get deferred during an unrelated waitForSyncReply() whereas InterpretQueuedKeyEvent (sync)
+        gets dispatched right away.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::keyEvent):
+
 2012-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -1424 +1424 @@
         handled = performDefaultBehaviorForKeyEvent(keyboardEvent);
 
-    send(Messages::WebPageProxy::DidReceiveEvent(static_cast<uint32_t>(keyboardEvent.type()), handled));
+    // The receiving end relies on DidReceiveEvent and InterpretQueuedKeyEvent arriving in the same order they are sent
+    // (for keyboard events.) We set the DispatchMessageEvenWhenWaitingForSyncReply flag to ensure consistent ordering.
+    connection()->send(Messages::WebPageProxy::DidReceiveEvent(static_cast<uint32_t>(keyboardEvent.type()), handled), m_pageID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply);
 }